src: clean up generic counter implementation #60447
Merged
+9
−9
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This addresses late review comments for the recently landed cfbfc1b and aligns the new code with the pre-existing V8 fast call counters. Refs: nodejs#60434 (review)
nodejs-github-bot
added
c++
joyeecheung
approved these changes
Oct 28, 2025
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #60447 +/- ##
==========================================
+ Coverage 88.56% 88.57% +0.01%
==========================================
Files 704 704
Lines 207826 207826
Branches 40045 40050 +5
==========================================
+ Hits 184068 184091 +23
+ Misses 15800 15760 -40
- Partials 7958 7975 +17 🚀 New features to boost your workflow:
|
anonrig
approved these changes
Oct 28, 2025
mertcanaltin
approved these changes
Oct 28, 2025
mcollina
added
request-ci
|
Fast-track has been requested by @mcollina. Please 👍 to approve. |
aduh95
added
the
author ready
github-actions
bot
removed
the
request-ci
cjihrig
approved these changes
Oct 28, 2025
addaleax
added
commit-queue
nodejs-github-bot
removed
the
commit-queue
|
Landed in b470ba0 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
8 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This addresses late review comments for the recently landed cfbfc1b and aligns the new code with the pre-existing V8 fast call counters.
Refs: #60434 (review)