Skip to content

Conversation

@ChALkeR
Copy link
Member

@ChALkeR ChALkeR commented Nov 2, 2025

Fixes: #60552

Regression from: #49884

@nodejs-github-bot nodejs-github-bot added fs Issues and PRs related to the fs subsystem / file system. needs-ci PRs that need a full CI run. labels Nov 2, 2025
@ChALkeR ChALkeR marked this pull request as ready for review November 2, 2025 18:39
@ChALkeR ChALkeR force-pushed the chalker/regression/3 branch 3 times, most recently from 026ae18 to 0fe5718 Compare November 2, 2025 19:20
@codecov
Copy link

codecov bot commented Nov 2, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 88.55%. Comparing base (dbe45b7) to head (5142f4e).
⚠️ Report is 3 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main   #60553      +/-   ##
==========================================
+ Coverage   88.54%   88.55%   +0.01%     
==========================================
  Files         704      704              
  Lines      207843   207853      +10     
  Branches    40044    40056      +12     
==========================================
+ Hits       184028   184069      +41     
+ Misses      15858    15802      -56     
- Partials     7957     7982      +25     
Files with missing lines Coverage Δ
lib/fs.js 98.19% <100.00%> (+<0.01%) ⬆️

... and 37 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@ChALkeR ChALkeR force-pushed the chalker/regression/3 branch from 0fe5718 to 5142f4e Compare November 2, 2025 20:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

fs Issues and PRs related to the fs subsystem / file system. needs-ci PRs that need a full CI run.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

fs: flush option ignored when writing/appending strings

2 participants