Skip to content

child_process: add getMemoryUsage() method to ChildProcess #60782

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

child_process: add getMemoryUsage() method to ChildProcess #60782

wants to merge 1 commit into from
+309 −0

Conversation

@geekdroid07
Copy link

@geekdroid07 geekdroid07 commented Nov 19, 2025

Summary

  • Expose ChildProcess.prototype.getMemoryUsage() via IPC, including request tracking, error propagation, and serialization.
  • Add regression tests plus a fixture exercising the happy path and failure cases (child stopped, IPC closed).
  • Document the new API and error codes (ERR_CHILD_PROCESS_MEMORY_USAGE_FAILED, ERR_CHILD_PROCESS_NOT_RUNNING) in
    • doc/api/child_process.md
    • doc/api/errors.md

Testing

python ./tools/test.py parallel/test-child-process-get-memory-usage
make lint-js

@nodejs-github-bot nodejs-github-bot added c++ Issues and PRs that require attention from people who are familiar with C++. lib / src Issues and PRs related to general changes in the lib or src directory. needs-ci PRs that need a full CI run. labels Nov 19, 2025
addaleax
addaleax reviewed Nov 19, 2025
View reviewed changes
doc/api/child_process.md
#### `subprocess.getMemoryUsage()`
<!-- YAML
added: v25.2.1
Copy link
Member

@addaleax addaleax Nov 19, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
added: v25.2.1
added: REPLACEME

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@addaleax addaleax addaleax left review comments

At least 1 approving review is required to merge this pull request.

Assignees

No one assigned

Labels

c++ Issues and PRs that require attention from people who are familiar with C++. lib / src Issues and PRs related to general changes in the lib or src directory. needs-ci PRs that need a full CI run.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@geekdroid07 @addaleax @nodejs-github-bot