Skip to content

Conversation

@legendecas
Copy link
Member

This helps js2c processing the node.gypi correctly when a string contains a quote.

Refs: #60703

This helps js2c processing the node.gypi correctly when a string
contains a quote.
@nodejs-github-bot nodejs-github-bot added build Issues and PRs related to build files or the CI. needs-ci PRs that need a full CI run. tools Issues and PRs related to the tools directory. labels Nov 20, 2025
@codecov
Copy link

codecov bot commented Nov 20, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 88.55%. Comparing base (0b6ae6d) to head (52dd9e8).
⚠️ Report is 21 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main   #60794      +/-   ##
==========================================
+ Coverage   88.04%   88.55%   +0.51%     
==========================================
  Files         703      703              
  Lines      208260   208249      -11     
  Branches    40068    40153      +85     
==========================================
+ Hits       183360   184417    +1057     
+ Misses      16840    15838    -1002     
+ Partials     8060     7994      -66     

see 100 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@legendecas legendecas added the request-ci Add this label to start a Jenkins CI on a PR. label Nov 21, 2025
@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Nov 21, 2025
@nodejs-github-bot
Copy link
Collaborator

@nodejs-github-bot
Copy link
Collaborator

@nodejs-github-bot
Copy link
Collaborator

@aduh95 aduh95 added author ready PRs that have at least one approval, no pending requests for changes, and a CI started. commit-queue Add this label to land a pull request using GitHub Actions. labels Nov 22, 2025
@nodejs-github-bot nodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Nov 22, 2025
@nodejs-github-bot nodejs-github-bot merged commit 7fd3688 into nodejs:main Nov 22, 2025
83 checks passed
@nodejs-github-bot
Copy link
Collaborator

Landed in 7fd3688

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

author ready PRs that have at least one approval, no pending requests for changes, and a CI started. build Issues and PRs related to build files or the CI. needs-ci PRs that need a full CI run. tools Issues and PRs related to the tools directory.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants