Skip to content

Conversation

@marco-ippolito
Copy link
Member

This PR does few things:

  • renamed testRunner namespace to test, this is a breaking change, but given its an experimental feature I guess it's all right. I added a warning so that its easier for users to migrate. The reason is to enabled the feature of implicitly enabling namespaces flags
  • added --test and --permission to the config file
  • fixed webstorage idk why it was not up to date I guess because of reverts
  • now --test,--watch, --permission are enabled by default if the namespace is passed

@nodejs-github-bot
Copy link
Collaborator

Review requested:

  • @nodejs/config
  • @nodejs/security-wg
  • @nodejs/test_runner

@nodejs-github-bot nodejs-github-bot added c++ Issues and PRs that require attention from people who are familiar with C++. lib / src Issues and PRs related to general changes in the lib or src directory. needs-ci PRs that need a full CI run. labels Nov 21, 2025
@marco-ippolito marco-ippolito changed the title Fix config improvement src: implicitly enable namespace in config Nov 21, 2025
@codecov
Copy link

codecov bot commented Nov 21, 2025

Codecov Report

❌ Patch coverage is 88.88889% with 2 lines in your changes missing coverage. Please review.
✅ Project coverage is 88.54%. Comparing base (d729bec) to head (95f4f38).
⚠️ Report is 4 commits behind head on main.

Files with missing lines Patch % Lines
src/node_config_file.cc 88.88% 0 Missing and 2 partials ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main   #60798      +/-   ##
==========================================
- Coverage   88.55%   88.54%   -0.01%     
==========================================
  Files         703      703              
  Lines      208259   208280      +21     
  Branches    40162    40169       +7     
==========================================
+ Hits       184415   184418       +3     
- Misses      15844    15873      +29     
+ Partials     8000     7989      -11     
Files with missing lines Coverage Δ
src/node_options.cc 77.85% <ø> (+0.10%) ⬆️
src/node_options.h 97.89% <ø> (+0.03%) ⬆️
src/node_config_file.cc 81.95% <88.88%> (+0.66%) ⬆️

... and 31 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Copy link
Member

@JakobJingleheimer JakobJingleheimer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🙌 I think this will also mitigate a long-standing composition problem (wherein additional flags cannot be set by a "parent" command because they're appended to the base command, and --test must be last).

Copy link
Member

@RafaelGSS RafaelGSS left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@marco-ippolito marco-ippolito added request-ci Add this label to start a Jenkins CI on a PR. author ready PRs that have at least one approval, no pending requests for changes, and a CI started. labels Nov 21, 2025
@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Nov 21, 2025
@nodejs-github-bot
Copy link
Collaborator

@nodejs-github-bot
Copy link
Collaborator

@nodejs-github-bot
Copy link
Collaborator

@marco-ippolito marco-ippolito added config Issues or PRs related to the config subsystem commit-queue-rebase Add this label to allow the Commit Queue to land a PR in several commits. commit-queue Add this label to land a pull request using GitHub Actions. labels Nov 22, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

author ready PRs that have at least one approval, no pending requests for changes, and a CI started. c++ Issues and PRs that require attention from people who are familiar with C++. commit-queue Add this label to land a pull request using GitHub Actions. commit-queue-rebase Add this label to allow the Commit Queue to land a PR in several commits. config Issues or PRs related to the config subsystem lib / src Issues and PRs related to general changes in the lib or src directory. needs-ci PRs that need a full CI run.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants