-
-
Notifications
You must be signed in to change notification settings - Fork 33.8k
src: implicitly enable namespace in config #60798
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
|
Review requested:
|
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #60798 +/- ##
==========================================
- Coverage 88.55% 88.54% -0.01%
==========================================
Files 703 703
Lines 208259 208280 +21
Branches 40162 40169 +7
==========================================
+ Hits 184415 184418 +3
- Misses 15844 15873 +29
+ Partials 8000 7989 -11
🚀 New features to boost your workflow:
|
JakobJingleheimer
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🙌 I think this will also mitigate a long-standing composition problem (wherein additional flags cannot be set by a "parent" command because they're appended to the base command, and --test must be last).
a4a4acb to
95f4f38
Compare
RafaelGSS
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
This PR does few things:
testRunnernamespace totest, this is a breaking change, but given its an experimental feature I guess it's all right. I added a warning so that its easier for users to migrate. The reason is to enabled the feature of implicitly enabling namespaces flags--testand--permissionto the config filewebstorageidk why it was not up to date I guess because of reverts--test,--watch,--permissionare enabled by default if the namespace is passed