Skip to content

src: remove unused private field #60802

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
+0 −1
Open

src: remove unused private field #60802

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion src/node.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1462,7 +1462,6 @@ class NODE_EXTERN CallbackScope {
CallbackScope(CallbackScope&&) = delete;

private:
void* resource_storage_global_;
Copy link
Member

@legendecas legendecas Nov 22, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This structure is a public API and changing the private fields will change the size of the struct and cause ABI incompatibility.

This field was named as reserved_.

This should be a semver-major change.

Copy link
Member Author

@targos targos Nov 22, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm ok to keep it if it's reserved for something. Do you have a suggestion for an explaining comment?

union {
v8::Local<v8::Object> local;
v8::Global<v8::Object>* global_ptr;
Expand Down
Loading