-
-
Notifications
You must be signed in to change notification settings - Fork 33.8k
util: move deprecated util._extend() to EoL
#60812
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
|
Review requested:
|
00e47e3 to
0424c81
Compare
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #60812 +/- ##
==========================================
+ Coverage 88.43% 88.55% +0.11%
==========================================
Files 703 703
Lines 208235 208231 -4
Branches 40085 40155 +70
==========================================
+ Hits 184162 184397 +235
+ Misses 16069 15829 -240
- Partials 8004 8005 +1
🚀 New features to boost your workflow:
|
|
|
|
First, I'm going to write a codemod for this deprecation to move forward with user that use this api directly. |
benjamingr
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think the benefit (we don't have to maintain it) is low and the breakage is big with this one.
|
IMO benefit is:
|
|
We already have a deprecation so users know they should not use this API. Breaking millions of installations to teach users not to use an API sounds like a very aggressive/breaking move to me and I would rather we don't unless we find a way to avoid the breakage. |
|
What if we land this in v25 so it's will be on v26 LTS it's mean the gap between two LTS is sufficient. |
We throw an error? I thought we just emit a warning don't we? |
My bad miss wording. yeah I mean warning |
Description
Granting DEP0060 (old one) to End of life and remove it form source code. First time I do that I'm not sure if I do it correctly
Comparison