Skip to content

Update Ada and url web-platform tests #61315

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
anonrig wants to merge 4 commits into
base: main
Choose a base branch
from
Open

Update Ada and url web-platform tests #61315

anonrig wants to merge 4 commits into from
+1,928 −726

Conversation

@anonrig
Copy link
Member

@anonrig anonrig commented Jan 8, 2026

Let's update Ada that comes with several performance improvements.

@nodejs-github-bot
Copy link
Collaborator

nodejs-github-bot commented Jan 8, 2026

Review requested:

  • @nodejs/security-wg
  • @nodejs/url
  • @nodejs/web-standards

@nodejs-github-bot nodejs-github-bot added dependencies Pull requests that update a dependency file. needs-ci PRs that need a full CI run. labels Jan 8, 2026
@anonrig anonrig added the commit-queue-rebase Add this label to allow the Commit Queue to land a PR in several commits. label Jan 8, 2026
@anonrig anonrig requested review from JonasBa and lemire January 8, 2026 14:45
@anonrig anonrig added the request-ci Add this label to start a Jenkins CI on a PR. label Jan 8, 2026
@anonrig anonrig requested a review from jasnell January 8, 2026 15:44
@codecov
Copy link

codecov bot commented Jan 8, 2026 •
edited
Loading

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 88.53%. Comparing base (842448b) to head (0d270be).
⚠️ Report is 5 commits behind head on main.

Additional details and impacted files 
@@            Coverage Diff             @@
##             main   #61315      +/-   ##
==========================================
+ Coverage   88.00%   88.53%   +0.53%     
==========================================
  Files         704      704              
  Lines      208739   208739              
  Branches    40196    40272      +76     
==========================================
+ Hits       183706   184817    +1111     
+ Misses      16992    15916    -1076     
+ Partials     8041     8006      -35

see 100 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@github-actions github-actions bot added request-ci-failed An error occurred while starting CI via request-ci label, and manual interventon is needed. and removed request-ci Add this label to start a Jenkins CI on a PR. labels Jan 8, 2026
@github-actions
Copy link
Contributor

github-actions bot commented Jan 8, 2026

Failed to start CI
   ⚠  No approving reviews found
   ✘  Refusing to run CI on potentially unsafe PR
https://github.com/nodejs/node/actions/runs/20832022492

@anonrig anonrig requested a review from KhafraDev January 8, 2026 22:20
@KhafraDev KhafraDev added request-ci Add this label to start a Jenkins CI on a PR. and removed request-ci-failed An error occurred while starting CI via request-ci label, and manual interventon is needed. labels Jan 9, 2026
mcollina
mcollina approved these changes Jan 9, 2026
View reviewed changes
Copy link
Member

@mcollina mcollina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Jan 9, 2026
@nodejs-github-bot
Copy link
Collaborator

nodejs-github-bot commented Jan 9, 2026

CI: https://ci.nodejs.org/job/node-test-pull-request/70739/

@nodejs-github-bot
Copy link
Collaborator

nodejs-github-bot commented Jan 9, 2026

CI: https://ci.nodejs.org/job/node-test-pull-request/70750/

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mcollina mcollina mcollina approved these changes

@KhafraDev KhafraDev KhafraDev approved these changes

@lemire lemire Awaiting requested review from lemire

@JonasBa JonasBa Awaiting requested review from JonasBa

@jasnell jasnell Awaiting requested review from jasnell

Assignees

No one assigned

Labels

commit-queue-rebase Add this label to allow the Commit Queue to land a PR in several commits. dependencies Pull requests that update a dependency file. needs-ci PRs that need a full CI run.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@anonrig @nodejs-github-bot @mcollina @KhafraDev