tools: fix vcbuild lint-js-build #61318
Open
+2
−2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nodejs-github-bot
added
build
anonrig
approved these changes
Jan 9, 2026
avivkeller
approved these changes
Jan 9, 2026
avivkeller
added
author ready
lpinca
approved these changes
Jan 9, 2026
cjihrig
approved these changes
Jan 9, 2026
github-actions
bot
removed
the
request-ci
Collaborator
legendecas
approved these changes
Jan 9, 2026
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently on Windows we cannot run
vcbuild.bat lint-jsbecause thelint-js-buildis skipped: after thelint-cpp:label we go to thelint-js:label. Since thelint-js-buildis never run, we cannot run thelint-js.This PR fixes the issue by going to
lint-js-build:label after probing thelint-cpp:label.It also fixes running the
vcbuild.bat lint-mdon Windows.This change was originally added in the PR #60916, but it is better to address this issue in a separate PR.