Skip to content

feat(ci): request reviews from API experts #8040

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

feat(ci): request reviews from API experts #8040

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
78cec81
feat(ci): request reviews from API experts
avivkeller Aug 5, 2025
dcc651f
Update request-codeowner-review.yml
avivkeller Aug 11, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 5 additions & 1 deletion .github/CODEOWNERS
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -39,6 +39,10 @@ docs @nodejs/nodejs-website @nodejs/web-infra
apps/site/pages/en/blog/release @nodejs/releasers
apps/site/pages/en/blog/announcements @nodejs/releasers

# Specific content
# The following users DO NOT have write access, and their review is requested
# via a GitHub action.
apps/site/pages/en/learn/diagnostics @nodejs/diagnostics
apps/site/pages/en/learn/getting-started/security-best-practices.md @nodejs/security-wg
apps/site/pages/en/learn/manipulating-files @nodejs/fs
apps/site/pages/en/learn/test-runner @nodejs/test_runner
apps/site/pages/en/learn/typescript @nodejs/typescript
21 changes: 21 additions & 0 deletions .github/workflows/request-codeowner-review.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,21 @@
name: Request Codeowner Reviews

on:
pull_request_target:
types: [opened]

permissions:
contents: read
pull-requests: write

jobs:
request-reviews:
runs-on: ubuntu-latest
steps:
- name: Checkout
uses: actions/checkout@11bd71901bbe5b1630ceea73d27597364c9af683 # v4.2.2

- name: Request Codeowner Reviews
uses: avivkeller/request-codeowner-review@0acf2fd074226a86efc85ff0356242fc35d68b32 # v1.1.0
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also, if you want, you can ask for this action to be moved to @pkgjs. It’s not certain that the package-maintenance team will accept it, but it’s worth a try.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it's good area for this action

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We only need to move it if there are security concerns about it being hosted from my account, which, since it's a GitHub action (which are SHA pinned, and not Node.js-specific), I don't believe there are.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

if it's on pkgjs it's easier for other project to use it. But here on this case I don't care about where is it and who maintain it

with:
token: ${{ secrets.GITHUB_TOKEN }}
Loading