Skip to content

Conversation

@RafaelGSS
Copy link
Member

@RafaelGSS RafaelGSS requested a review from a team as a code owner August 14, 2025 21:12
@RafaelGSS RafaelGSS added the github_actions:pull-request Trigger Pull Request Checks label Aug 14, 2025
@vercel
Copy link

vercel bot commented Aug 14, 2025

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Preview Updated (UTC)
nodejs-org Ready Preview Aug 14, 2025 9:13pm

@codecov
Copy link

codecov bot commented Aug 14, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 72.80%. Comparing base (cd078de) to head (8635d62).
⚠️ Report is 1 commits behind head on main.
✅ All tests successful. No failed tests found.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #8077      +/-   ##
==========================================
- Coverage   72.82%   72.80%   -0.03%     
==========================================
  Files          96       96              
  Lines        8328     8328              
  Branches      214      214              
==========================================
- Hits         6065     6063       -2     
- Misses       2262     2264       +2     
  Partials        1        1              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@github-actions
Copy link
Contributor

github-actions bot commented Aug 14, 2025

Lighthouse Results

URL Performance Accessibility Best Practices SEO Report
/en 🟠 89 🟢 100 🟢 100 🟢 100 🔗
/en/about 🟢 100 🟢 97 🟢 100 🟠 88 🔗
/en/about/previous-releases 🟢 100 🟢 93 🟢 100 🟠 89 🔗
/en/download 🟢 95 🟢 100 🟢 100 🟢 100 🔗
/en/blog 🟢 99 🟢 100 🟢 96 🟢 100 🔗

@avivkeller
Copy link
Member

@nodejs/web-infra WDYT about automating this blog post PR? @RafaelGSS will it make the releasers' lives easier?

@RafaelGSS
Copy link
Member Author

RafaelGSS commented Aug 14, 2025

@nodejs/web-infra WDYT about automating this blog post PR? @RafaelGSS will it make the releasers' lives easier?

If you automate the review process, yes. Creating the post is already "automated" by release-post script. We just need to publish it faster.

@RafaelGSS RafaelGSS enabled auto-merge August 14, 2025 21:17
@RafaelGSS
Copy link
Member Author

I will ignore the release's review... as I'm one of them.

@RafaelGSS RafaelGSS disabled auto-merge August 14, 2025 21:19
@RafaelGSS RafaelGSS merged commit 5e81a17 into main Aug 14, 2025
15 checks passed
@RafaelGSS RafaelGSS deleted the add-nodejs-v24.6.0-release branch August 14, 2025 21:19
@avivkeller
Copy link
Member

avivkeller commented Aug 14, 2025

If you automate the review process, yes. Creating the post is already "automated" by release-post script. We just need to publish it faster.

I could imagine a workflow like

flowchart TD
    B[Release]
    B --> C[Workflow dispatch triggered by @nodejs-github-bot in nodejs.org]
    C --> D[Release blog post created]
    D --> E[Reviewed by user with write access]
    E -- Approve --> F[Merge initiated]

Loading

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants