Skip to content

fix(translation): don't translate OpenJS Foundation #8129

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix(translation): don't translate OpenJS Foundation #8129

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion apps/site/components/withFooter.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,10 @@ const WithFooter: FC = () => {

const navigation = {
socialLinks,
footerLinks: footerLinks.map(link => ({ ...link, text: t(link.text) })),
footerLinks: footerLinks.map(link => ({
...link,
text: link.label ? t(link.label) : (link.text as string),
})),
};

const primary = (
Expand Down
10 changes: 5 additions & 5 deletions apps/site/navigation.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -34,23 +34,23 @@
"footerLinks": [
{
"link": "https://trademark-policy.openjsf.org/",
"text": "components.containers.footer.links.trademarkPolicy"
"label": "components.containers.footer.links.trademarkPolicy"
},
{
"link": "https://privacy-policy.openjsf.org/",
"text": "components.containers.footer.links.privacyPolicy"
"label": "components.containers.footer.links.privacyPolicy"
},
{
"link": "https://github.com/openjs-foundation/cross-project-council/blob/main/CODE_OF_CONDUCT.md",
"text": "components.containers.footer.links.codeOfConduct"
"label": "components.containers.footer.links.codeOfConduct"
},
{
"link": "https://github.com/nodejs/node/security/policy",
"text": "components.containers.footer.links.security"
"label": "components.containers.footer.links.security"
},
{
"link": "https://openjsf.org/",
"text": "components.containers.footer.links.openJSFoundation"
"text": "OpenJS Foundation"
}
],
"socialLinks": [
Expand Down
3 changes: 2 additions & 1 deletion apps/site/types/navigation.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,8 @@ import type { HTMLAttributeAnchorTarget } from 'react';
import type { IntlMessageKeys } from './i18n';

export type FooterConfig = {
text: IntlMessageKeys;
label?: IntlMessageKeys;
text?: string;
link: string;
};

Expand Down
1 change: 0 additions & 1 deletion packages/i18n/src/locales/en.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,6 @@
"containers": {
"footer": {
"links": {
"openJSFoundation": "OpenJS Foundation",
"trademarkPolicy": "Trademark Policy",
"privacyPolicy": "Privacy Policy",
"codeOfConduct": "Code of Conduct",
Expand Down
1 change: 0 additions & 1 deletion packages/i18n/src/locales/fr.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,6 @@
"containers": {
"footer": {
"links": {
"openJSFoundation": "Fondation OpenJS",
"trademarkPolicy": "Politique de Marque",
"privacyPolicy": "Politique de confidentialité",
"codeOfConduct": "Code de conduite",
Expand Down
1 change: 0 additions & 1 deletion packages/i18n/src/locales/ja.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,6 @@
"containers": {
"footer": {
"links": {
"openJSFoundation": "OpenJS Foundation",
"trademarkPolicy": "商標ポリシー",
"privacyPolicy": "プライバシーポリシー",
"codeOfConduct": "行動規範",
Expand Down
1 change: 0 additions & 1 deletion packages/i18n/src/locales/ro.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,6 @@
"containers": {
"footer": {
"links": {
"openJSFoundation": "Fundația OpenJS",
"trademarkPolicy": "Politică de mărci comerciale",
"privacyPolicy": "Politică de confidențialitate",
"codeOfConduct": "Cod de conduită",
Expand Down
1 change: 0 additions & 1 deletion packages/i18n/src/locales/uk.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,6 @@
"containers": {
"footer": {
"links": {
"openJSFoundation": "OpenJS Foundation",
"trademarkPolicy": "Політика торгових марок",
"privacyPolicy": "Політика конфіденційності",
"versionSupport": "Підтримка версії",
Expand Down
Loading