-
-
Notifications
You must be signed in to change notification settings - Fork 6.4k
feat(search): use new Orama components #8175
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Co-authored-by: Aviv Keller <[email protected]> Signed-off-by: Aileen Villanueva Lecuona <[email protected]>
Co-authored-by: Aviv Keller <[email protected]> Signed-off-by: Aileen Villanueva Lecuona <[email protected]>
Co-authored-by: Aviv Keller <[email protected]> Signed-off-by: Aileen Villanueva Lecuona <[email protected]>
Co-authored-by: Aviv Keller <[email protected]> Signed-off-by: Aileen Villanueva Lecuona <[email protected]>
Co-authored-by: Aviv Keller <[email protected]> Signed-off-by: Aileen Villanueva Lecuona <[email protected]>
Thank you! I'll cover them today! |
@avivkeller @canerakdas fyi I've addressed the latest points reported, thank you. |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #8175 +/- ##
==========================================
+ Coverage 76.64% 76.66% +0.02%
==========================================
Files 115 115
Lines 9618 9635 +17
Branches 322 322
==========================================
+ Hits 7372 7387 +15
- Misses 2245 2247 +2
Partials 1 1 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! Awesome work 🚀 🐢
@g-francesca Can you fix or remove the playwright tests? After that, this'll be ready to land! |
Lighthouse Results
|
Yes! Some selectors were still targeting old web components. @avivkeller I added |
Thanks @avivkeller. So I've updated the HTML element targeted as search-results wrapper (I've targeted the wrong one before by mistake). I tried to run the playwright tests locally, and they're passing. |
Can you update https://github.com/nodejs/nodejs.org/blob/main/.github/workflows/sync-orama.yml to use the new API keys? See https://github.com/nodejs/nodejs.org/actions/runs/18316807448/job/52159169199?pr=8175 |
This PR supersedes #7971 and integrates the new Orama components, powered by the new OramaCore backend.
Description
New components - React-based to replace the old WebComponents-based ones. New backend (OramaCore instead of old Orama Cloud), all hosted and maintained on https://app.orama.com. Credentials have been shared privately with the repository maintainers on Slack.
Validation
Tested locally and on remote demo environment.
Related Issues
Check List
pnpm format
to ensure the code follows the style guide.pnpm test
to check if all tests are passing.pnpm build
to check if the website builds without errors.