Skip to content

Conversation

canerakdas
Copy link
Member

Description

This PR aims to fix the height of the Skeleton used with Select and to adjust the alignment of the select on the download page

Validation

Download select must be aligned

Related Issues

Fixes #8208

@Copilot Copilot AI review requested due to automatic review settings October 6, 2025 20:43
@canerakdas canerakdas requested a review from a team as a code owner October 6, 2025 20:43
Copy link
Contributor

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR fixes alignment issues in the download options UI by adjusting CSS properties for Skeleton and Select components. The changes ensure proper vertical alignment of select elements on the download page.

  • Added inline-flex and align-middle properties to Skeleton component for consistent alignment
  • Added align-middle property to Select component to match the Skeleton alignment

Reviewed Changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.

File Description
packages/ui-components/src/Common/Skeleton/index.module.css Added inline-flex and align-middle classes to improve skeleton alignment
packages/ui-components/src/Common/Select/index.module.css Added align-middle class to ensure consistent select component alignment

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

Copy link

vercel bot commented Oct 6, 2025

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Preview Updated (UTC)
nodejs-org Ready Ready Preview Oct 6, 2025 8:44pm

Copy link

codecov bot commented Oct 6, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 76.60%. Comparing base (39850b9) to head (2b0b387).
✅ All tests successful. No failed tests found.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #8209      +/-   ##
==========================================
- Coverage   76.64%   76.60%   -0.05%     
==========================================
  Files         115      115              
  Lines        9618     9618              
  Branches      322      323       +1     
==========================================
- Hits         7372     7368       -4     
- Misses       2245     2249       +4     
  Partials        1        1              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Collaborator

@bmuenzenmeyer bmuenzenmeyer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

works!

i was messing with items-center in my debugging, and missed skeleton completely!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Misalignment of download options
4 participants