Skip to content

fix: PartnerIcon Accessibility #8489

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
avivkeller merged 2 commits into from
Dec 31, 2025
Merged

fix: PartnerIcon Accessibility #8489

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
fe28fe6
fix: PartnerIcon Accessibility
malav2110 Dec 29, 2025
0d2da57
fix: remove redundant aria-label from Tooltip in PartnersList
malav2110 Dec 30, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 9 additions & 2 deletions apps/site/components/Common/Partners/index.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -38,9 +38,11 @@ const renderSmallPartner = (partner: Partner) => {
return (
<Tooltip
key={partner.id}
asChild
aria-label={partner.name}
content={<div className={style.tooltip}>{partner.name}</div>}
>
<PartnerButton size="small" href={partner.href}>
<PartnerButton aria-label={partner.name} size="small" href={partner.href}>
<Logo.Favicon />
</PartnerButton>
</Tooltip>
Expand All @@ -51,7 +53,12 @@ const renderLargePartner = (partner: Partner) => {
const Logo = PartnerLogos[partner.id];

return (
<PartnerButton key={partner.id} size="large" href={partner.href}>
<PartnerButton
aria-label={partner.name}
key={partner.id}
size="large"
href={partner.href}
>
<Logo.Logo />
</PartnerButton>
);
Expand Down