Skip to content

fix(ui): Learn Page Landmark Accessibility issues #8551

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
malav2110 wants to merge 3 commits into
base: main
Choose a base branch
from
Open

fix(ui): Learn Page Landmark Accessibility issues #8551

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
5b1dc26
fix(ui): Learn Page Landmark Accessibility issues
malav2110 Jan 15, 2026
602e4f7
fix(ui): remove role attribute from Banner component for accessibilit…
malav2110 Jan 15, 2026
6bc5cdc
fix(ui): enhance aria label for Banner and Metabar as a prop
malav2110 Jan 16, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion packages/ui-components/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"name": "@node-core/ui-components",
"version": "1.5.4",
"version": "1.5.5",
"type": "module",
"exports": {
"./*": [
Expand Down
8 changes: 6 additions & 2 deletions packages/ui-components/src/Common/Banner/index.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,9 +10,13 @@ const Banner: FC<PropsWithChildren<BannerProps>> = ({
type = 'default',
children,
}) => (
<div className={`${styles.banner} ${styles[type] || styles.default}`}>
<section
className={`${styles.banner} ${styles[type] || styles.default}`}
role="region"
aria-label="Announcement"
Copy link
Member

@avivkeller avivkeller Jan 15, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Instead, and this should apply to the Banner changes as well, this component should accept ...props, and forward those props to the aside. We try not to hard code values for translations

Copy link
Contributor Author

@malav2110 malav2110 Jan 16, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

addressed.

>
{children}
</div>
</section>
);

export default Banner;
4 changes: 2 additions & 2 deletions packages/ui-components/src/Containers/MetaBar/index.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -31,7 +31,7 @@ const MetaBar: FC<MetaBarProps> = ({
);

return (
<div className={styles.wrapper}>
<aside className={styles.wrapper} aria-label="Article metadata">
<dl>
{Object.entries(items)
.filter(([, value]) => !!value)
Expand Down Expand Up @@ -65,7 +65,7 @@ const MetaBar: FC<MetaBarProps> = ({
</>
)}
</dl>
</div>
</aside>
);
};

Expand Down
Loading