Skip to content

fix: handle invalid dates properly #266

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
flakey5 merged 6 commits into from
Jan 28, 2025
Merged

fix: handle invalid dates properly #266

Changes from 1 commit
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
39bd93a
fix: handle invalid dates properly
flakey5 Jan 21, 2025
593af38
review
flakey5 Jan 27, 2025
a8af496
format
flakey5 Jan 27, 2025
cc7c751
Update src/utils/request.ts
flakey5 Jan 27, 2025
406733e
fix ci
flakey5 Jan 27, 2025
557135d
format
flakey5 Jan 27, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 10 additions & 2 deletions src/utils/request.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,12 +30,15 @@ export function parseUrl(request: Request): URL | undefined {
}

export function parseConditionalHeaders(headers: Headers): ConditionalHeaders {
const ifModifiedSince = headers.has('if-modified-since')
let ifModifiedSince = headers.has('if-modified-since')
? new Date(headers.get('if-modified-since')!)
: undefined;

if (ifModifiedSince instanceof Date) {
ifModifiedSince.setSeconds(ifModifiedSince.getSeconds() + 1);
} else {
// Invalid date
ifModifiedSince = undefined;
}

const ifMatch = headers.has('if-match')
Expand All @@ -46,10 +49,15 @@ export function parseConditionalHeaders(headers: Headers): ConditionalHeaders {
? headers.get('if-none-match')!.replaceAll('"', '')
: undefined;

const ifUnmodifiedSince = headers.has('if-unmodified-since')
let ifUnmodifiedSince = headers.has('if-unmodified-since')
? new Date(headers.get('if-unmodified-since')!)
: undefined;

if (!(ifUnmodifiedSince instanceof Date)) {
// Invalid date
ifUnmodifiedSince = undefined;
}

const range = headers.has('range')
? parseRangeHeader(headers.get('range')!)
: undefined;
Expand Down
Loading