fix: only alert for force pushes to mai #283
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: flakey5 <[email protected]>
ovflowd
reviewed
Feb 4, 2025
| if: > | ||
| github.repository == 'nodejs/release-cloudflare-worker' && | ||
| github.actor != 'github-merge-queue[bot]' | ||
| github.event.forced |
Member
There was a problem hiding this comment.
Shouldn't we alert any push that was done through a PR merge? But also with this :)
Member
Author
There was a problem hiding this comment.
I don't really think each pr merge should be an alert, the idea was to alert for direct pushes to the main branch w/o a pr
ovflowd
approved these changes
Feb 4, 2025
Member
|
Instead of alerting on force pushes, I would recommend to make force pushes (or any pushes other than PR merges) impossible with a branch ruleset. |
Member
|
That should also be the case -- @flakey5 you have admin permissions you should be able to make changes. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.