Skip to content

actions: alert on update link failure & fix deploy action #355

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
flakey5 merged 2 commits into from
Mar 27, 2025
Merged

actions: alert on update link failure & fix deploy action #355

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
b145068
actions: alert on update link failure & fix deploy action
flakey5 Mar 27, 2025
b6a4384
Apply suggestions from code review
flakey5 Mar 27, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
21 changes: 8 additions & 13 deletions .github/workflows/deploy.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -45,16 +45,11 @@ jobs:

- name: Alert on Failure
if: failure() && github.repository == 'nodejs/release-cloudflare-worker'
runs-on: ubuntu-latest
steps:
- name: Slack Notification
uses: rtCamp/action-slack-notify@c33737706dea87cd7784c687dadc9adf1be59990 # 2.3.2
env:
SLACK_COLOR: '#DE512A'
SLACK_ICON: https://github.com/nodejs.png?size=48
SLACK_TITLE: Deployment failed (${{ github.ref }})
SLACK_MESSAGE: |
A deployment of the Release Worker has failed.
SLACK_USERNAME: nodejs-bot
SLACK_WEBHOOK: ${{ secrets.SLACK_WEBHOOK }}

uses: rtCamp/action-slack-notify@c33737706dea87cd7784c687dadc9adf1be59990 # 2.3.2
env:
SLACK_COLOR: '#DE512A'
SLACK_ICON: https://github.com/nodejs.png?size=48
SLACK_TITLE: Deployment failed (${{ github.ref }})
SLACK_MESSAGE: A deployment of the Release Worker has failed.
SLACK_USERNAME: nodejs-bot
SLACK_WEBHOOK: ${{ secrets.SLACK_WEBHOOK }}
14 changes: 9 additions & 5 deletions .github/workflows/update-links.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -63,10 +63,14 @@ jobs:
env:
GITHUB_TOKEN: ${{ secrets.GH_BOT_TOKEN }}

- name: Deploy to Production
Copy link
Member

@MattIPv4 MattIPv4 Mar 27, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I should've asked, but I assume the removal of this step is intentional?

Copy link
Member Author

@flakey5 flakey5 Mar 27, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

aghhh thanks, #356

if: steps.git_auto_commit.outputs.changes_detected == 'true'
run: |
gh workflow run deploy.yml
- name: Alert on Failure
if: failure() && github.repository == 'nodejs/release-cloudflare-worker'
uses: rtCamp/action-slack-notify@c33737706dea87cd7784c687dadc9adf1be59990 # 2.3.2
env:
GITHUB_TOKEN: ${{ secrets.GH_BOT_TOKEN }}
SLACK_COLOR: '#DE512A'
SLACK_ICON: https://github.com/nodejs.png?size=48
SLACK_TITLE: Update links failed (${{ github.ref }})
SLACK_MESSAGE: The `update-links.yml` action has failed.
SLACK_USERNAME: nodejs-bot
SLACK_WEBHOOK: ${{ secrets.SLACK_WEBHOOK }}

Loading