fix: do spec-compliant date parsing #409
Conversation
| @@ -0,0 +1,295 @@ | |||
| /** | |||
There was a problem hiding this comment.
This is grabbed straight from undici, do we really need to have a copy of this in our code? Is there a 3rd party library we can use? I really want to avoid us from maintaining such kind of code.
There was a problem hiding this comment.
@nodejs/undici I hope you don't mind the ping, but is this date parsing logic something y'all would consider exposing?
It looks like a couple of utils are currently exposed: https://github.com/nodejs/undici/blob/674ae24d6e61a3ef62b4b3e8677fcae52c0fa068/index.js#L60-L63
So, would it be viable to add https://github.com/nodejs/undici/blob/674ae24d6e61a3ef62b4b3e8677fcae52c0fa068/lib/util/date.js to that?
There was a problem hiding this comment.
This is grabbed straight from undici, do we really need to have a copy of this in our code? Is there a 3rd party library we can use? I really want to avoid us from maintaining such kind of code.
Why not? We have parsing logic already for other things such as the range header
Signed-off-by: flakey5 <[email protected]>
|
I'm gonna merge & deploy this now just to stop us from getting spammed with more alerts, but we can continue talking about if we want to use a package for this here or in an issue or on Slack if y'all want |
|
I think best thing would be an issue or PR in undici to expose this util? |
No description provided.