chore(templating): use mustache #474
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
Author
|
@nodejs/web-infra you have edit access to my fork, and are free to push any commits to fix any mistakes I may have made :-) cc @flakey5 |
avivkeller
commented
Jun 24, 2025
avivkeller
force-pushed
the
chore/templating
branch
from
84ed264 to
8ed11e0
Compare
flakey5
reviewed
Jun 24, 2025
Member
flakey5
left a comment
flakey5
left a comment
There was a problem hiding this comment.
Lgtm from a quick skim, will do a formal approval once I'm not afk, thank you!
flakey5
approved these changes
Jun 24, 2025
Member
Author
|
Bump for land @nodejs/web-infra |
ovflowd
approved these changes
Jul 7, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As discussed on Slack, using Mustache (rather than Handlebars) produces a much smaller bundle.