Skip to content

Commit 10f6219

Browse files
committed
docs: update OpenSSF Best practices Gold criteria
Ref: https://www.bestpractices.dev/en/projects/29?criteria_level=2
1 parent 91f35e7 commit 10f6219

File tree

1 file changed

+13
-13
lines changed

1 file changed

+13
-13
lines changed

tools/ossf_best_practices/gold_criteria.md

Lines changed: 13 additions & 13 deletions
Original file line numberDiff line numberDiff line change
@@ -33,7 +33,7 @@ Context:
3333

3434
> The project MUST have a "bus factor" of 2 or more. (URL required)
3535
36-
**Met. https://github.com/nodejs/node/blob/main/GOVERNANCE.md**
36+
**Met. https://github.com/nodejs/node/blob/main/README.md#current-project-team-members**
3737

3838
Context:
3939
- [CII Best Practices: Basics](https://github.com/coreinfrastructure/best-practices-badge/blob/a51ed45fdcd8e2959781a86929f561521ac2e0e0/docs/other.md#upgrade-basics-1)
@@ -53,7 +53,7 @@ Context:
5353

5454
> The project MUST include a copyright statement in each source file, identifying the copyright holder (e.g., the [project name] contributors).
5555
56-
**Unmet**
56+
**Unmet. see https://github.com/nodejs/security-wg/issues/1187**
5757

5858
Context:
5959
- [CII Best Practices: Basics](https://github.com/coreinfrastructure/best-practices-badge/blob/a51ed45fdcd8e2959781a86929f561521ac2e0e0/docs/other.md#upgrade-basics-1)
@@ -63,7 +63,7 @@ Context:
6363

6464
> The project MUST include a license statement in each source file. This MAY be done by including the following inside a comment near the beginning of each file: SPDX-License-Identifier: [SPDX license expression for project](https://spdx.dev/ids/#how)
6565
66-
**Unmet**
66+
**Unmet. see see: https://github.com/nodejs/security-wg/issues/1187**
6767

6868
Context:
6969
- [CII Best Practices: Basics](https://github.com/coreinfrastructure/best-practices-badge/blob/a51ed45fdcd8e2959781a86929f561521ac2e0e0/docs/other.md#upgrade-basics-1)
@@ -76,7 +76,7 @@ Context:
7676

7777
> The project's source repository MUST use a common distributed version control software (e.g., git or mercurial).
7878
79-
**Met**
79+
**Met. Repository on GitHub, which uses git. git is distributed**
8080

8181
Context:
8282
- [CII Best Practices: Change Control](https://github.com/coreinfrastructure/best-practices-badge/blob/a51ed45fdcd8e2959781a86929f561521ac2e0e0/docs/other.md#upgrade-change-control-1)
@@ -113,15 +113,15 @@ Context:
113113

114114
> The project MUST document its code review requirements, including how code review is conducted, what must be checked, and what is required to be acceptable. (URL required)
115115
116-
**Met. The process is documented: https://github.com/nodejs/node/blob/a51ed45fdcd8e2959781a86929f561521ac2e0e0/doc/contributing/pull-requests.md#reviewing-pull-requests**
116+
**Met. The process is documented: https://github.com/nodejs/node/blob/main/doc/contributing/pull-requests.md#reviewing-pull-requests**
117117

118118
Context:
119119
- [CII Best Practices: Quality](https://github.com/coreinfrastructure/best-practices-badge/blob/a51ed45fdcd8e2959781a86929f561521ac2e0e0/docs/other.md#upgrade-quality-1)
120120
- [Team Discussion](https://github.com/nodejs/security-wg/pull/956#discussion_r1307403399)
121121

122122
> The project MUST have at least 50% of all proposed modifications reviewed before release by a person other than the author, to determine if it is a worthwhile modification and free of known issues which would argue against its inclusion
123123
124-
**Met. The process is documented: https://github.com/nodejs/node/blob/a51ed45fdcd8e2959781a86929f561521ac2e0e0/doc/contributing/pull-requests.md#reviewing-pull-requests and we use additional tools like the OSSF Scorecard to monitor it**
124+
**Met. The process is documented: https://github.com/nodejs/node/blob/main/doc/contributing/pull-requests.md#reviewing-pull-requests and we use additional tools like the OSSF Scorecard to monitor it**
125125

126126
Context:
127127
- [CII Best Practices: Quality](https://github.com/coreinfrastructure/best-practices-badge/blob/a51ed45fdcd8e2959781a86929f561521ac2e0e0/docs/other.md#upgrade-quality-1)
@@ -144,7 +144,7 @@ Context:
144144

145145
> A test suite MUST be invocable in a standard way for that language.
146146
147-
**Met**
147+
**Met. make or batch file, executed using python. Warning: URL required, but no URL found.**
148148

149149
Context:
150150
- [CII Best Practices: Quality](https://github.com/coreinfrastructure/best-practices-badge/blob/a51ed45fdcd8e2959781a86929f561521ac2e0e0/docs/other.md#upgrade-quality-1)
@@ -187,7 +187,7 @@ _Note that some software does not need to use cryptographic mechanisms. If your
187187

188188
> The software produced by the project MUST support secure protocols for all of its network communications, such as SSHv2 or later, TLS1.2 or later (HTTPS), IPsec, SFTP, and SNMPv3. Insecure protocols such as FTP, HTTP, telnet, SSLv3 or earlier, and SSHv1 MUST be disabled by default, and only enabled if the user specifically configures it. If the software produced by the project does not support network communications, select "not applicable" (N/A).
189189
190-
**N/A**
190+
**N/A. The project does not produce software that supports network communications, the final user is responsible for that when using Node.js.**
191191

192192
Context:
193193
- [CII Best Practices: Security](https://github.com/coreinfrastructure/best-practices-badge/blob/a51ed45fdcd8e2959781a86929f561521ac2e0e0/docs/other.md#upgrade-security-1)
@@ -198,7 +198,7 @@ Context:
198198

199199
> The software produced by the project MUST, if it supports or uses TLS, support at least TLS version 1.2. Note that the predecessor of TLS was called SSL. If the software does not use TLS, select "not applicable" (N/A).
200200
201-
**Met**
201+
**Met. Warning: Requires lengthier justification.**
202202

203203
Context:
204204
- [CII Best Practices: Security](https://github.com/coreinfrastructure/best-practices-badge/blob/a51ed45fdcd8e2959781a86929f561521ac2e0e0/docs/other.md#upgrade-security-1)
@@ -210,7 +210,7 @@ Context:
210210

211211
> The project website, repository (if accessible via the web), and download site (if separate) MUST include key hardening headers with nonpermissive values. (URL required)
212212
213-
**Met**
213+
**Unmet. One or more of the required security hardening headers is missing.**
214214

215215
Context:
216216
- [CII Best Practices: Security](https://github.com/coreinfrastructure/best-practices-badge/blob/a51ed45fdcd8e2959781a86929f561521ac2e0e0/docs/other.md#upgrade-security-1)
@@ -229,7 +229,7 @@ Context:
229229

230230
> Hardening mechanisms MUST be used in the software produced by the project so that software defects are less likely to result in security vulnerabilities. (URL required)
231231
232-
**N/A**
232+
**N/A. The the final user has the power to decide, see: Node.js thread model (https://github.com/nodejs/node/blob/main/SECURITY.md#the-nodejs-threat-model)**
233233

234234
Context:
235235
- [CII Best Practices: Security](https://github.com/coreinfrastructure/best-practices-badge/blob/a51ed45fdcd8e2959781a86929f561521ac2e0e0/docs/other.md#upgrade-security-1)
@@ -241,15 +241,15 @@ Context:
241241

242242
> The project MUST apply at least one dynamic analysis tool to any proposed major production release of the software produced by the project before its release.
243243
244-
**Unmet. Infrastructure for running several different dynamic analysis tools is provided by the project. See: https://github.com/nodejs/node/tree/master/tools**
244+
**Met. Infrastructure for running several different dynamic analysis tools is provided by the project. See: https://github.com/nodejs/node/tree/master/tools**
245245

246246
Context:
247247
- [CII Best Practices: Analysis](https://github.com/coreinfrastructure/best-practices-badge/blob/a51ed45fdcd8e2959781a86929f561521ac2e0e0/docs/other.md#upgrade-analysis-1)
248248

249249

250250
> The project SHOULD include many run-time assertions in the software it produces and check those assertions during dynamic analysis.
251251
252-
**Unmet**
252+
**Unmet. Warning: Requires lengthier justification.**
253253

254254
Context:
255255
- [CII Best Practices: Analysis](https://github.com/coreinfrastructure/best-practices-badge/blob/a51ed45fdcd8e2959781a86929f561521ac2e0e0/docs/other.md#upgrade-analysis-1)

0 commit comments

Comments
 (0)