Skip to content

fix(#3975): do not unref timeout #3977

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ronag merged 2 commits into from
Dec 31, 2024
Merged

fix(#3975): do not unref timeout #3977

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
b6d553a
fix(#3975): do not unref timeout
metcoder95 Dec 31, 2024
403181f
test: add testing
metcoder95 Dec 31, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion lib/handler/retry-handler.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -133,7 +133,7 @@ class RetryHandler {
? Math.min(retryAfterHeader, maxTimeout)
: Math.min(minTimeout * timeoutFactor ** (counter - 1), maxTimeout)

setTimeout(() => cb(null), retryTimeout).unref()
setTimeout(() => cb(null), retryTimeout)
}

onResponseStart (controller, statusCode, headers, statusMessage) {
Expand Down
Loading