don't check AbortSignal maxListeners on some node versions#4045
Merged
KhafraDev merged 1 commit intonodejs:mainfrom Feb 6, 2025
Merged
don't check AbortSignal maxListeners on some node versions#4045KhafraDev merged 1 commit intonodejs:mainfrom
KhafraDev merged 1 commit intonodejs:mainfrom
Conversation
KhafraDev
commented
Feb 3, 2025
| try { | ||
| abortSignalHasEventHandlerLeakWarning = getMaxListeners(new AbortController().signal) > 0 | ||
| } catch { | ||
| abortSignalHasEventHandlerLeakWarning = false |
Member
Author
There was a problem hiding this comment.
getMaxListeners throws with 0 signals (nodejs/node@752c0b8)
Comment on lines
-427
to
-428
| // Third-party AbortControllers may not work with these. | ||
| // See, https://github.com/nodejs/undici/pull/1910#issuecomment-1464495619. |
Member
Author
There was a problem hiding this comment.
we don't support third party AbortControllers anymore
metcoder95
approved these changes
Feb 4, 2025
Merged
Closed
ronag
added a commit
to nxtedition/undici
that referenced
this pull request
Mar 14, 2025
* nodejs/main: (23 commits) Bumped v7.5.0 (nodejs#4091) Removed clients with unrecoverable errors from the Pool (nodejs#4088) feat: Allow disabling autoSelectFamily in an Agent (nodejs#4070) chore: update cache tests (nodejs#4027) fix: Fix retry-handler.js when retry-after header is a Date (nodejs#4084) feat: add mock call history to access request configuration in test (nodejs#4029) feat(docs): button to switch dark and light mode (nodejs#4044) Bumped v7.4.0 (nodejs#4071) fix: fix EnvHttpProxyAgent for the Node.js bundle (nodejs#4064) chore: update WPT (nodejs#4062) chore: update WPT (nodejs#4028) fix: handle missing vary header values (nodejs#4031) fix: do not throw unhandled exception when data is undefined in interceptor.reply (nodejs#4036) test: fix windows wpt (nodejs#4050) feat: mark `EnvHttpProxyAgent` as stable (nodejs#4049) don't check AbortSignal maxListeners on some node versions (nodejs#4045) feat(docs): copy to clipboard button (nodejs#4037) docs: fix incorrect method signature of `onResponseError` (nodejs#4030) docs: document about global dispatcher and errors (nodejs#3987) (nodejs#4014) chore: update WPT (nodejs#4011) ...
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
refs: #4032