Skip to content

feat(DEP0081): migrate fs.truncatefs.ftruncate & fs.truncateSyncfs.ftruncateSync#135

Merged
AugustinMauroy merged 32 commits intomainfrom
feat(`fs-truncate-fs-depreciation`)
Oct 8, 2025
Merged

feat(DEP0081): migrate fs.truncatefs.ftruncate & fs.truncateSyncfs.ftruncateSync#135
AugustinMauroy merged 32 commits intomainfrom
feat(`fs-truncate-fs-depreciation`)

Conversation

@AugustinMauroy
Copy link
Member

Related issue

close #122

@avivkeller avivkeller changed the title Feat(fs truncate fd depreciation): introduce feat(fs-truncate-fd-deprecation): introduce Jul 27, 2025
Copy link
Member

@avivkeller avivkeller left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's "Deprecation", not "Depreciation"

@AugustinMauroy
Copy link
Member Author

It's "Deprecation", not "Depreciation"

🤦🏼

@AugustinMauroy AugustinMauroy requested review from a team and avivkeller July 27, 2025 16:43
@avivkeller avivkeller dismissed their stale review July 27, 2025 21:36

Dismissed

@AugustinMauroy AugustinMauroy force-pushed the feat(`fs-truncate-fs-depreciation`) branch from edbf9e5 to cb967d2 Compare July 29, 2025 21:20
@AugustinMauroy AugustinMauroy force-pushed the feat(`fs-truncate-fs-depreciation`) branch from cb967d2 to 13c2ddc Compare July 29, 2025 21:22
Copy link
Member

@JakobJingleheimer JakobJingleheimer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🙌

@AugustinMauroy AugustinMauroy added the awaiting reviewer Author has responded and needs action from the reviewer label Sep 27, 2025
@JakobJingleheimer JakobJingleheimer removed the awaiting reviewer Author has responded and needs action from the reviewer label Oct 8, 2025
@AugustinMauroy AugustinMauroy merged commit c508cb7 into main Oct 8, 2025
30 checks passed
@JakobJingleheimer JakobJingleheimer added the dep:v24 Migration handles deprecation introduced in node v24 label Oct 18, 2025
@JakobJingleheimer JakobJingleheimer deleted the feat(`fs-truncate-fs-depreciation`) branch December 13, 2025 11:51
@JakobJingleheimer JakobJingleheimer changed the title feat(fs-truncate-fd-deprecation): introduce feat(DEP0081): migrate fs.truncatefs.ftruncate & fs.truncateSyncfs.ftruncateSync Jan 17, 2026
@JakobJingleheimer JakobJingleheimer added this to the 22.x → 24.x milestone Jan 17, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

dep:v24 Migration handles deprecation introduced in node v24

Projects

None yet

Development

Successfully merging this pull request may close these issues.

feat: handle fs.truncate() using a file descriptor depreciation

5 participants