feat(DEP0191): migrate node:repl methods → node:module replacements#149
Merged
AugustinMauroy merged 19 commits intomainfrom Oct 18, 2025
Merged
feat(DEP0191): migrate node:repl methods → node:module replacements#149AugustinMauroy merged 19 commits intomainfrom
node:repl methods → node:module replacements#149AugustinMauroy merged 19 commits intomainfrom
Conversation
AugustinMauroy
force-pushed
the
feat(`repl-builtinModules`)
branch
from
44e207e to
f8fcfb0
Compare
brunocroh
reviewed
Jul 31, 2025
Member
|
I think this recipe can be a great use case for the new utility function when it is ready to use, what do you think? #151 |
Member
Author
YESS but need to wait approval on the pr |
AugustinMauroy
force-pushed
the
feat(`repl-builtinModules`)
branch
from
803ec84 to
827fcc9
Compare
AugustinMauroy
force-pushed
the
feat(`repl-builtinModules`)
branch
from
827fcc9 to
c38bfc1
Compare
AugustinMauroy
force-pushed
the
feat(`repl-builtinModules`)
branch
from
1518b45 to
5ae19aa
Compare
AugustinMauroy
force-pushed
the
feat(`repl-builtinModules`)
branch
from
5ae19aa to
e3497b4
Compare
avivkeller
reviewed
Aug 12, 2025
Member
avivkeller
left a comment
avivkeller
left a comment
There was a problem hiding this comment.
Started a review.
There's a lot of places where you check both properties, those can probably be refactored to common helpers
Co-Authored-By: Aviv Keller <me@aviv.sh>
brunocroh
reviewed
Aug 14, 2025
brunocroh
approved these changes
Aug 18, 2025
avivkeller
approved these changes
Aug 18, 2025
Member
Author
|
missing dynamic import |
AugustinMauroy
added
the
awaiting reviewer
JakobJingleheimer
added
the
dep:v24
JakobJingleheimer
approved these changes
Oct 16, 2025
Member
JakobJingleheimer
left a comment
JakobJingleheimer
left a comment
There was a problem hiding this comment.
Thanks for this!
Some code quality things, but nothing blocking. Could handle subsequently if you prefer.
JakobJingleheimer
added
awaiting author
Co-Authored-By: Jacob Smith <3012099+JakobJingleheimer@users.noreply.github.com>
AugustinMauroy
added
awaiting reviewer
Member
Author
|
@JakobJingleheimer I think I have covered all piece |
JakobJingleheimer
approved these changes
Oct 18, 2025
Member
JakobJingleheimer
left a comment
JakobJingleheimer
left a comment
There was a problem hiding this comment.
🙌 Much nicer to read 😁
JakobJingleheimer
added
awaiting author
JakobJingleheimer
changed the title
repl builtin modules): introduce node:repl methods → node: module replacements
JakobJingleheimer
changed the title
node:repl methods → node: module replacementsnode:repl methods → node:module replacements
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Add new codemod to handle this depreciation
Related issue
Close #121