Skip to content

Conversation

AugustinMauroy
Copy link
Member

@AugustinMauroy AugustinMauroy commented Aug 4, 2025

Description

Writing team documents based on Jacob proposal #153 (comment)

Requesting review from the team first then let's ask TSC for validation

Related issue

close #153

@AugustinMauroy AugustinMauroy requested a review from Copilot August 4, 2025 21:34
Copy link
Contributor

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR establishes formal team governance documentation by creating a comprehensive TEAM.md file that outlines team membership, rights, nomination processes, and expulsion procedures.

  • Adds detailed team governance structure including voting mechanisms and membership criteria
  • Updates contribution guidelines to clarify that reviewers must be team members
  • Establishes clear policies for active/inactive membership and administrative procedures

Reviewed Changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 3 comments.

File Description
TEAM.md Creates comprehensive team governance document covering membership, rights, nomination criteria, and expulsion procedures
CONTRIBUTING.md Updates reviewer requirements to specify that approvals must come from team members

@AugustinMauroy AugustinMauroy requested a review from a team August 4, 2025 21:41
Copy link
Member

@JakobJingleheimer JakobJingleheimer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why "gouverance" instead of governance?

@AugustinMauroy
Copy link
Member Author

Why "gouverance" instead of governance?

Parceque 😂

@AugustinMauroy AugustinMauroy changed the title chore(team): write "gouverance" chore(team): write "goverance" Aug 5, 2025
@JakobJingleheimer JakobJingleheimer changed the title chore(team): write "goverance" chore(team): write governance Aug 5, 2025
@JakobJingleheimer
Copy link
Member

JakobJingleheimer commented Aug 5, 2025

I corrected the spelling and removed the quotes (which made it look suspicious or imaginary).

Copy link
Member

@JakobJingleheimer JakobJingleheimer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we're good after these last few edits and Aviv's more broad/less specific criteria (unless anyone else has a strong opinion?).

@JakobJingleheimer JakobJingleheimer dismissed alexbit-codemod’s stale review August 11, 2025 21:55

The cited concern is resolved :)

Copy link
Member

@JakobJingleheimer JakobJingleheimer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Otherwise LGTM 🙂

@AugustinMauroy AugustinMauroy requested a review from a team August 17, 2025 14:12
@AugustinMauroy
Copy link
Member Author

cc @nodejs/tsc

Hey, we've drafted some guidelines for the team. I think it would be a good idea to get your approval before implementing them.


Maintainers are also responsible for creating tags on the repository's `HEAD` branch to trigger the CI pipeline and initiate a release. Tags must adhere to the format `vX.Y.Z@workspace`, where `X.Y.Z` represents the version number and `workspace` specifies the npm workspace (e.g., `v1.2.3@codemod`).

## Team removal
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please remove all this section, I don't think it's in the purview of a team to self-moderate.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why is it not in the purview of a team to moderate itself? AFAIK, there is historic precedent, as well as the TSC is itself self-moderating.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Meta: team nomination guidelines
7 participants