-
-
Notifications
You must be signed in to change notification settings - Fork 20
chore(team): write governance #159
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR establishes formal team governance documentation by creating a comprehensive TEAM.md file that outlines team membership, rights, nomination processes, and expulsion procedures.
- Adds detailed team governance structure including voting mechanisms and membership criteria
- Updates contribution guidelines to clarify that reviewers must be team members
- Establishes clear policies for active/inactive membership and administrative procedures
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 3 comments.
File | Description |
---|---|
TEAM.md | Creates comprehensive team governance document covering membership, rights, nomination criteria, and expulsion procedures |
CONTRIBUTING.md | Updates reviewer requirements to specify that approvals must come from team members |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why "gouverance"
instead of governance?
Parceque 😂 |
I corrected the spelling and removed the quotes (which made it look suspicious or imaginary). |
Co-authored-by: Jacob Smith <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we're good after these last few edits and Aviv's more broad/less specific criteria (unless anyone else has a strong opinion?).
The cited concern is resolved :)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Otherwise LGTM 🙂
cc @nodejs/tsc Hey, we've drafted some guidelines for the team. I think it would be a good idea to get your approval before implementing them. |
|
||
Maintainers are also responsible for creating tags on the repository's `HEAD` branch to trigger the CI pipeline and initiate a release. Tags must adhere to the format `vX.Y.Z@workspace`, where `X.Y.Z` represents the version number and `workspace` specifies the npm workspace (e.g., `v1.2.3@codemod`). | ||
|
||
## Team removal |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please remove all this section, I don't think it's in the purview of a team to self-moderate.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why is it not in the purview of a team to moderate itself? AFAIK, there is historic precedent, as well as the TSC is itself self-moderating.
Description
Writing team documents based on Jacob proposal #153 (comment)
Requesting review from the team first then let's ask TSC for validation
Related issue
close #153