feat(process-assert-to-assert): introduce

[matheusmorett2]

Closes #197

Add codemod recipe process-assert-to-assert to handle deprecation DEP0100.

Before

const { assert: nodeAssert, env } = require("process");
nodeAssert(condition, "Assertion valid");

After

const assert = require("node:assert");
const { env } = require("process");
assert(condition, "Assertion valid");

---

Fix: remove-binding.ts

handle scenario where have alias in require

[AugustinMauroy]

I didn't see any test for that kind cases

import process from "node:process"

But good first pr

[brunocroh]

Awesome first contribution 🎉, Thank you @matheusmorett2 !

Just small fixes needed

[brunocroh]

Remove process.assert.strictEqual reference, I think it was added by mistake. This scenario does not exist. Add bold formatting to the before/after text.

Suggested change

	* Before:
	* ```js
	* process.assert(value);
	* process.assert.strictEqual(a, b);
	* ```
	*
	* After:
	* ```js
	* import assert from "node:assert";
	* assert(value);
	* assert.strictEqual(a, b);
	* ```
	* **Before**:
	* ```js
	* process.assert(value);
	* ```
	*
	* **After**:
	* ```js
	* import assert from "node:assert";
	* assert(value);
	* ```

[matheusmorett2]

actually my code wasn't working for assert.strictEqual but is should

https://nodejs.org/api/assert.html

so I kept the assert.strictEqual

[matheusmorett2]

Also added the bold on before and after words

[brunocroh]

My point is that the TypeScript docs say that the code in the before block, process.assert.strictEqual(a, b), will be updated to use assert.strictEqual.

However, process.assert.strictEqual does not exist, at least I couldn’t find any reference to it.

[brunocroh]

Please fix the conflict in the remove-binding file

[AugustinMauroy]

For require call not in cjs context the transformed code may be wrong.

For example this before

import { createRequire} from 'node:module';
const require = createRequire(import.meta.dirname)

process.assert(true);

Broken after with the current implementation

const assert = require('node:assert');
import { createRequire} from 'node:module';
const require = createRequire(import.meta.dirname)

assert(true);

In this case I expect that require is undefined.

Solutions:

1. Try to found a logic that handle that.
2. Add it at inline comment so we know for the future

[AugustinMauroy]

Suggested change

	replaceRules.push({
	replaceRules.push({

[AugustinMauroy]

Suggested change

	function processImports(moduleName: "process" | "node:process") {
	function processImports(moduleName: string) {

Utilities used inside this function have regex to catch both usage of node:process or process. So you can simplify the logic of this function.

[AugustinMauroy]

@brunocroh correct me if I am wrong but here dinging also include process so code after the condition is useless ?

[brunocroh]

I think so

[AugustinMauroy]

Suggested change

	{
	kind: "pair_pattern",
	},
	{
	kind: "shorthand_property_identifier_pattern",
	},
	{
	kind: "pair_pattern" },
	{ kind: "shorthand_property_identifier_pattern" },

I found that simplest to read idk what you think about that

[AugustinMauroy]

Suggested change

	See [DEP0100](https://github.com/nodejs/userland-migrations/issues/197).
	See [DEP0100](https://nodejs.org/api/deprecations.html#DEP100).

[AugustinMauroy]

Ps: verify the link I am on mobile for this review