-
-
Notifications
You must be signed in to change notification settings - Fork 31
feat(mocha-to-node-test-runner) : Migrate Mocha v8 tests to Node.js test runner (v22, v24+) #313
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
Xstoudi
wants to merge
10
commits into
nodejs:main
Choose a base branch
from
Xstoudi:feature/mocha-to-node-test-runner
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
10 commits
Select commit
Hold shift + click to select a range
7dc0c74
wip
Xstoudi 11d3fd6
wip
Xstoudi 99e0ab4
wip
Xstoudi ef337d5
wip
Xstoudi 759291a
wip
Xstoudi 7262ab1
Apply suggestions from code review
Xstoudi ebdc996
wip
Xstoudi be89c04
fix
Xstoudi ead6abc
fix
Xstoudi cf520d2
fix
Xstoudi File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Some comments aren't visible on the classic Files Changed page.
There are no files selected for viewing
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Oops, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,171 @@ | ||
| # Mocha to Node.js Test Runner | ||
|
|
||
| This recipe migrate Mocha v8 tests to Node.js test runner (v22, v24+) | ||
|
|
||
| ## Features | ||
Xstoudi marked this conversation as resolved.
Show resolved
Hide resolved
|
||
|
|
||
| - Automatically adds `node:test` imports/requires | ||
| - Converts global `describe`, `it`, and hooks to imported versions | ||
| - Transforms `done` callbacks to `(t, done)` signature | ||
| - Converts `this.skip()` to `t.skip()` | ||
| - Converts `this.timeout(N)` to `{ timeout: N }` options | ||
| - Preserves function styles (doesn't convert between `function()` and arrow functions) | ||
| - Supports both CommonJS and ESM | ||
|
|
||
| ## Examples | ||
|
|
||
| ### Example 1: Basic | ||
|
|
||
| ```diff | ||
Xstoudi marked this conversation as resolved.
Show resolved
Hide resolved
|
||
| ``` | ||
| const assert = require('assert'); | ||
| +const { describe, it } = require('node:test'); | ||
|
|
||
| describe('Array', function() { | ||
| describe.skip('#indexOf()', function() { | ||
| it('should return -1 when the value is not present', function() { | ||
| const arr = [1, 2, 3]; | ||
| assert.strictEqual(arr.indexOf(4), -1); | ||
| }); | ||
| }); | ||
| }); | ||
| ``` | ||
|
|
||
| ### Example 2: Async | ||
|
|
||
| ```diff | ||
Xstoudi marked this conversation as resolved.
Show resolved
Hide resolved
|
||
| ``` | ||
| const assert = require('assert'); | ||
| +const { describe, it } = require('node:test'); | ||
| describe('Async Test', function() { | ||
| - it('should complete after a delay', async function(done) { | ||
| + it('should complete after a delay', async function(t, done) { | ||
| const result = await new Promise(resolve => setTimeout(() => resolve(42), 100)); | ||
| assert.strictEqual(result, 42); | ||
| }); | ||
| }); | ||
| ``` | ||
|
|
||
| ### Example 3: Hooks | ||
|
|
||
| ```diff | ||
Xstoudi marked this conversation as resolved.
Show resolved
Hide resolved
|
||
| ``` | ||
| const assert = require('assert'); | ||
| const fs = require('fs'); | ||
| +const { describe, before, after, it } = require('node:test'); | ||
| describe('File System', () => { | ||
| before(function() { | ||
| fs.writeFileSync('test.txt', 'Hello, World!'); | ||
| }); | ||
|
|
||
| after(() => { | ||
| fs.unlinkSync('test.txt'); | ||
| }); | ||
|
|
||
| it('should read the file', () => { | ||
| const content = fs.readFileSync('test.txt', 'utf8'); | ||
| assert.strictEqual(content, 'Hello, World!'); | ||
| }); | ||
| }); | ||
| ``` | ||
|
|
||
| ### Example 4: Done | ||
|
|
||
| ```diff | ||
Xstoudi marked this conversation as resolved.
Show resolved
Hide resolved
|
||
| ``` | ||
| const assert = require('assert'); | ||
| +const { describe, it } = require('node:test'); | ||
| describe('Callback Test', function() { | ||
| - it('should call done when complete', function(done) { | ||
| + it('should call done when complete', function(t, done) { | ||
| setTimeout(() => { | ||
| assert.strictEqual(1 + 1, 2); | ||
| done(); | ||
| }, 100); | ||
| }); | ||
| }) | ||
| ``` | ||
|
|
||
| ### Example 5: Skipped | ||
|
|
||
| ```diff | ||
Xstoudi marked this conversation as resolved.
Show resolved
Hide resolved
|
||
| ``` | ||
| const assert = require('assert'); | ||
| +const { describe, it } = require('node:test'); | ||
| describe('Skipped Test', () => { | ||
| it.skip('should not run this test', () => { | ||
| assert.strictEqual(1 + 1, 3); | ||
| }); | ||
| - it('should also be skipped', () => { | ||
| - this.skip(); | ||
| + it('should also be skipped', (t) => { | ||
| + t.skip(); | ||
| assert.strictEqual(1 + 1, 3); | ||
| }); | ||
|
|
||
| - it('should also be skipped 2', (done) => { | ||
| - this.skip(); | ||
| + it('should also be skipped 2', (t, done) => { | ||
| + t.skip(); | ||
| assert.strictEqual(1 + 1, 3); | ||
| }); | ||
|
|
||
| - it('should also be skipped 3', x => { | ||
| - this.skip(); | ||
| + it('should also be skipped 3', (t, x) => { | ||
| + t.skip(); | ||
| assert.strictEqual(1 + 1, 3); | ||
| }); | ||
| }) | ||
| ``` | ||
|
|
||
| ### Example 6: Dynamic | ||
|
|
||
| ```diff | ||
Xstoudi marked this conversation as resolved.
Show resolved
Hide resolved
|
||
| ``` | ||
| const assert = require('assert'); | ||
| +const { describe, it } = require('node:test'); | ||
| describe('Dynamic Tests', () => { | ||
| const tests = [1, 2, 3]; | ||
|
|
||
| tests.forEach((test) => { | ||
Xstoudi marked this conversation as resolved.
Show resolved
Hide resolved
|
||
| it(`should handle test ${test}`, () => { | ||
| assert.strictEqual(test % 2, 0); | ||
| }); | ||
| }); | ||
| }); | ||
| ``` | ||
|
|
||
| ### Example 7: Timeouts | ||
|
|
||
| ```diff | ||
Xstoudi marked this conversation as resolved.
Show resolved
Hide resolved
|
||
| const assert = require('assert'); | ||
| -describe('Timeout Test', function() { | ||
| - this.timeout(500); | ||
| +const { describe, it } = require('node:test'); | ||
| +describe('Timeout Test', { timeout: 500 }, function() { | ||
| + | ||
| + | ||
| + it('should complete within 100ms', { timeout: 100 }, (t, done) => { | ||
|
|
||
| - it('should complete within 100ms', (done) => { | ||
| - this.timeout(100); | ||
| setTimeout(done, 500); // This will fail | ||
| }); | ||
|
|
||
| - it('should complete within 200ms', function(done) { | ||
| - this.timeout(200); | ||
| + it('should complete within 200ms', { timeout: 200 }, function(t, done) { | ||
| + | ||
| setTimeout(done, 100); // This will pass | ||
| }); | ||
| }); | ||
| ``` | ||
|
|
||
| ## Caveats | ||
|
|
||
| * `node:test` doesn't support the `retry` option that Mocha has, so any tests using that will need to be handled separately. | ||
|
|
||
| ## References | ||
| - [Node Test Runner](https://nodejs.org/api/test.html) | ||
| - [Mocha](https://mochajs.org/) | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,26 @@ | ||
| schema_version: "1.0" | ||
| name: "@nodejs/mocha-to-node-test-runner" | ||
| version: 1.0.0 | ||
| capabilities: | ||
| - fs | ||
| - child_process | ||
| description: Migrate Mocha v8 tests to Node.js test runner (v22, v24+) | ||
| author: Xavier Stouder | ||
| license: MIT | ||
| workflow: workflow.yaml | ||
| category: migration | ||
|
|
||
| targets: | ||
| languages: | ||
| - javascript | ||
| - typescript | ||
|
|
||
| keywords: | ||
| - transformation | ||
| - migration | ||
| - mocha | ||
| - test | ||
|
|
||
| registry: | ||
| access: public | ||
| visibility: public |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,24 @@ | ||
| { | ||
| "name": "@nodejs/mocha-to-node-test-runner", | ||
| "version": "1.0.0", | ||
| "description": "Migrate Mocha v8 tests to Node.js test runner (v22, v24+)", | ||
| "type": "module", | ||
| "scripts": { | ||
| "test": "npx codemod jssg test -l typescript ./src/workflow.ts ./" | ||
| }, | ||
| "repository": { | ||
| "type": "git", | ||
| "url": "git+https://github.com/nodejs/userland-migrations.git", | ||
| "directory": "recipes/mocha-to-node-test-runner", | ||
| "bugs": "https://github.com/nodejs/userland-migrations/issues" | ||
| }, | ||
| "author": "Richie McColl", | ||
| "license": "MIT", | ||
| "homepage": "https://github.com/nodejs/userland-migrations/blob/main/recipes/mocha-to-node-test-runner/README.md", | ||
| "devDependencies": { | ||
| "@codemod.com/jssg-types": "^1.3.1" | ||
| }, | ||
| "dependencies": { | ||
| "@nodejs/codemod-utils": "*" | ||
| } | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,8 @@ | ||
| import removeDependencies from '@nodejs/codemod-utils/remove-dependencies'; | ||
|
|
||
| /** | ||
| * Remove chalk and @types/chalk dependencies from package.json | ||
| */ | ||
| export default function removeMochaDependencies(): string | null { | ||
| return removeDependencies(['mocha', '@types/mocha']); | ||
| } |
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.