-
-
Notifications
You must be signed in to change notification settings - Fork 4
Meeting notes for 09/29 #45
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
avivkeller
wants to merge
11
commits into
main
Choose a base branch
from
meeting-notes-9-29
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+99
−0
Open
Changes from 2 commits
Commits
Show all changes
11 commits
Select commit
Hold shift + click to select a range
af6f249
Create 2025-09-29.md
avivkeller 21b3a0e
Update 2025-09-29.md
avivkeller 50ff788
Apply suggestion from @Copilot
avivkeller 7d74238
Apply suggestion from @Copilot
avivkeller 43ea675
Apply suggestion from @Copilot
avivkeller 778dd0e
Apply suggestion from @Copilot
avivkeller 6fb35cb
Apply suggestion from @Copilot
avivkeller 271f921
Apply suggestion from @Copilot
avivkeller 51df74c
Apply suggestion from @Copilot
avivkeller 481d463
Update meetings/2025-09-29.md
avivkeller 4aae6ed
Update meetings/2025-09-29.md
avivkeller File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,100 @@ | ||
# Node.js Web Team Meeting 2025-09-29 | ||
|
||
## Links | ||
|
||
* **GitHub Issue**: https://github.com/nodejs/web-team/issues/43 | ||
|
||
## Present | ||
|
||
* Aviv Keller @avivkeller | ||
* Claudio Wunder @ovflowd | ||
* Alex Bit @alexbit-codemod (Guest, Userland Migrations) | ||
* Dario Piotrowicz @dario-priotrowicz | ||
* Matt Cowley @MattIPv4 | ||
* Rene @Renegade334 (Guest, TypeScript) | ||
* Jake Bailey @jakebailey (Guest, TypeScript) | ||
* Brian Muenzenmeyer @bmuenzenmeyer | ||
* Bruno Rodriguez @brunocroh (Guest, Userland Migrations) | ||
|
||
## Agenda | ||
|
||
* Extracted from **web-agenda** labelled issues and pull requests from the **nodejs org** prior to the meeting. | ||
|
||
|
||
### nodejs/nodejs.org | ||
|
||
* content(`userland-migration`): make up to date [#8053](https://github.com/nodejs/nodejs.org/pull/8053) | ||
* Alex, Codemod explanation. Codemods are only used when they are officially endorsed | ||
* Alex, plan: | ||
* "Userland Migrations" blog cat | ||
* Migration guides | ||
* Changelogs | ||
* See other frameworks, like React, for inspiration | ||
* "Userland Migrations" learn | ||
* What is a codemod? | ||
* Basic description | ||
* **Not for migration guides** | ||
* Use Docs banner for migration guides | ||
* Claudio, Migrations don't need to go in Learn, it's for concepts, not "things" | ||
* Leave things light, people can use MDN for specifics | ||
* Release/Other blog posts are the ideal place for these | ||
* (Aviv +1) | ||
* It's important to understand that certain blog posts must come from a certain team, that's not entirely in the website team's control. Perhaps get in touch with Releasers and/or Marketing. | ||
* Brian, can we add banners _after_ the fact, since Codemod's take time to develop | ||
* Claudio, true, Codemod's won't be instantly ready, we'd need to change the banner dynamically. | ||
|
||
### nodejs/doc-kit | ||
|
||
* Generate Type Declarations [#437](https://github.com/nodejs/doc-kit/issues/437) | ||
* Brian, why doesn't Node.js ship it's own types | ||
avivkeller marked this conversation as resolved.
Outdated
Show resolved
Hide resolved
|
||
* Claudio, no runtime does, each provides out-of-house | ||
* It's hard for the system to know _which_ version of Node.js you are using, and thus, another package is ideal | ||
* It's hard to identify _where_ the types are | ||
* Jake, if it were bundled, we (Node.js) would be respnsosible for a lot of compat we aren't expert in | ||
avivkeller marked this conversation as resolved.
Outdated
Show resolved
Hide resolved
|
||
* Current issues: | ||
* "Goofy" types for cross-compat with the DOM | ||
* Too many manual changes | ||
* The script doesn't really use the docs *super* offten | ||
avivkeller marked this conversation as resolved.
Outdated
Show resolved
Hide resolved
|
||
* Claudio, we would like to reduce the manual work | ||
* New engine (`doc-kit`) can infer interfaces | ||
* Aviv, while making `doc-kit`, we noticed many issues with the current Structure | ||
* Rene, the source is _human_ readable, but not very _machine_ readable | ||
* Current tooling can't do multiple types in a single Array, i.e. `buffer.Blob` | ||
* It's hard to interop with the Web API | ||
* Making it machine readable it's fruitful, since it'll still need changes in TypeScript | ||
* Documentation isn't the primary focus of code review | ||
* If the docs were strongly-typed, it would help, but it would make them extremely rigid. | ||
* Claudio, this is something we can and should change | ||
* Jake, types are also generic, when, it reality, they are different in various TypeScript versions. | ||
avivkeller marked this conversation as resolved.
Outdated
Show resolved
Hide resolved
|
||
* In TS's DOM Lib, the raw spec is taken, converted to types, and patches are applied on top. | ||
* Brian, even if we don't make it perfect and hands-off, we can make it better | ||
* Aviv, we should bring these types to the collaborators, and work to make the docs rigid | ||
* Rene, unless there is a shift in code review, that'll always be a problem | ||
* We could, however, build better types in the markdown | ||
* Claudio, we have AST in our new generator to create very precise JSON | ||
* We can make this format entirely our own, as consumable and reliable as possible | ||
* It's worth it to make the DX high and the pain low | ||
* Claudio, DefinetelyTyped can import `doc-kit` for their parsing | ||
avivkeller marked this conversation as resolved.
Outdated
Show resolved
Hide resolved
|
||
* Aviv, we can add a generator to put it in a format best of them | ||
* Claudio, we can lint the docs to make their types compatible | ||
* Rene, we can leverage this, but garbage in -> garabage out | ||
avivkeller marked this conversation as resolved.
Outdated
Show resolved
Hide resolved
|
||
* It'll cause an awful lot of upstream changes | ||
* Aviv's PR to use the same list format was an example of something that helped standardize | ||
* The primary objective is to make the docs readable for DT maintainers | ||
* Claudio, if you (Rene + Jake) can look over the codebase, and find what stands out, and what is needed, now is the best time to make changes | ||
* We appreciate DTS, and we wan't to give back | ||
avivkeller marked this conversation as resolved.
Outdated
Show resolved
Hide resolved
|
||
* We have the ability to do so much | ||
* We do need to, however, change the status quo on the docs | ||
* | ||
avivkeller marked this conversation as resolved.
Outdated
Show resolved
Hide resolved
|
||
|
||
### nodejs/web-team | ||
|
||
* Create Means for Private Communications [#14](https://github.com/nodejs/web-team/issues/14) | ||
|
||
* Skipped as we ran out of time | ||
|
||
## Upcoming Meetings | ||
|
||
* **Node.js Project Calendar**: <https://nodejs.org/calendar> | ||
|
||
Click `+GoogleCalendar` at the bottom right to add to your own Google calendar. |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.