Fix potential vulnerable cloned function#3698
Open
npt-1707 wants to merge 1 commit intonodemcu:releasefrom
Open
Fix potential vulnerable cloned function#3698npt-1707 wants to merge 1 commit intonodemcu:releasefrom
npt-1707 wants to merge 1 commit intonodemcu:releasefrom
Conversation
Member
|
This disables loading Lua byte code. This is an essential feature on a resource constrained device. You provide no evidence of the alleged vulnerability and instead apply a sledge hammer approach buying an entire feature. I see no reason to give this PR credence. Please expand on your reasoning and add evidence please. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Our tool identified a potential vulnerability in a clone function
f_parser()inapp/lua/ldo.csourced from antirez/redis. These issues, originally reported in CVE-2015-4335, were resolved in the repository via this commit antirez/redis@fdf9d45.This PR applies the corresponding patch to fix the vulnerabilities in this codebase.
Please review at your convenience.