deps: update to protobuf v33.2 #398
Conversation
WalkthroughProtobuf compiler and runtime version bump from 6.33.0 to 6.33.2 across generated files, dependency proto headers, and version strings. Includes new feature defaults generation for Java and C++, Java nested file class detection helper functions, and Edition enum extension (EDITION_UNSTABLE = 9999). Changes
Estimated code review effort🎯 3 (Moderate) | ⏱️ ~20 minutes Areas requiring extra attention:
Suggested reviewers
Poem
Pre-merge checks and finishing touches❌ Failed checks (1 warning)
✅ Passed checks (2 passed)
✨ Finishing touches
🧪 Generate unit tests (beta)
📜 Recent review detailsConfiguration used: CodeRabbit UI Review profile: CHILL Plan: Pro ⛔ Files ignored due to path filters (16)
📒 Files selected for processing (72)
✅ Files skipped from review due to trivial changes (1)
🚧 Files skipped from review as they are similar to previous changes (43)
🧰 Additional context used🧠 Learnings (45)📚 Learning: 2025-12-03T14:32:27.692ZApplied to files:
📚 Learning: 2025-12-03T14:32:24.501ZApplied to files:
📚 Learning: 2025-12-03T14:34:02.613ZApplied to files:
📚 Learning: 2025-12-03T14:27:57.305ZApplied to files:
📚 Learning: 2025-12-03T14:32:27.692ZApplied to files:
📚 Learning: 2025-12-03T14:27:57.305ZApplied to files:
📚 Learning: 2025-12-03T14:32:27.692ZApplied to files:
📚 Learning: 2025-12-03T14:32:27.692ZApplied to files:
📚 Learning: 2025-12-03T14:35:32.707ZApplied to files:
📚 Learning: 2025-12-03T14:35:32.707ZApplied to files:
📚 Learning: 2025-12-03T14:33:50.104ZApplied to files:
📚 Learning: 2025-12-03T14:33:49.590ZApplied to files:
📚 Learning: 2025-12-03T14:30:51.421ZApplied to files:
📚 Learning: 2025-12-03T14:30:47.803ZApplied to files:
📚 Learning: 2025-12-03T14:35:32.707ZApplied to files:
📚 Learning: 2025-12-03T14:31:00.865ZApplied to files:
📚 Learning: 2025-12-03T14:31:00.865ZApplied to files:
📚 Learning: 2025-12-03T14:29:37.758ZApplied to files:
📚 Learning: 2025-12-03T14:35:21.897ZApplied to files:
📚 Learning: 2025-12-03T14:30:51.421ZApplied to files:
📚 Learning: 2025-12-03T14:35:32.707ZApplied to files:
📚 Learning: 2025-12-03T14:35:32.707ZApplied to files:
📚 Learning: 2025-12-03T14:31:33.011ZApplied to files:
📚 Learning: 2025-12-03T14:31:33.011ZApplied to files:
📚 Learning: 2025-12-03T14:31:33.011ZApplied to files:
📚 Learning: 2025-12-03T14:31:30.011ZApplied to files:
📚 Learning: 2025-12-03T14:30:47.803ZApplied to files:
📚 Learning: 2025-12-03T14:29:25.191ZApplied to files:
📚 Learning: 2025-12-03T14:35:34.369ZApplied to files:
📚 Learning: 2025-12-03T14:33:09.802ZApplied to files:
📚 Learning: 2025-12-03T14:34:18.928ZApplied to files:
📚 Learning: 2025-12-03T14:34:02.613ZApplied to files:
📚 Learning: 2025-12-03T14:34:02.613ZApplied to files:
📚 Learning: 2025-12-03T14:34:02.613ZApplied to files:
📚 Learning: 2025-12-03T14:34:02.613ZApplied to files:
📚 Learning: 2025-12-03T14:32:41.659ZApplied to files:
📚 Learning: 2025-12-03T14:32:26.248ZApplied to files:
📚 Learning: 2025-12-03T14:31:58.078ZApplied to files:
📚 Learning: 2025-12-03T14:31:54.774ZApplied to files:
📚 Learning: 2025-12-03T14:27:57.305ZApplied to files:
📚 Learning: 2025-12-03T14:40:17.411ZApplied to files:
📚 Learning: 2025-12-03T14:35:32.707ZApplied to files:
📚 Learning: 2025-12-03T14:35:34.369ZApplied to files:
📚 Learning: 2025-12-03T14:29:37.758ZApplied to files:
📚 Learning: 2025-12-03T14:29:36.526ZApplied to files:
🧬 Code graph analysis (6)deps/protobuf/src/google/protobuf/compiler/cpp/extension.h (1)
deps/protobuf/src/google/protobuf/compiler/java/full/message.cc (2)
deps/protobuf/src/google/protobuf/compiler/code_generator_unittest.cc (2)
deps/protobuf/src/google/protobuf/compiler/java/helpers.cc (1)
deps/protobuf/src/google/protobuf/cpp_features.pb.h (1)
deps/protobuf/src/google/protobuf/compiler/java/names.h (2)
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (8)
🔇 Additional comments (35)
Comment |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 2
♻️ Duplicate comments (3)
deps/protobuf/src/google/protobuf/wrappers.pb.cc (1)
4-4: Header version annotation aligned with updated protobuf runtimeThe updated
Protobuf C++ Version: 6.33.2banner matches the header and new runtime guard; no functional changes introduced here.agents/grpc/src/proto/common.pb.h (1)
4-19: Generated agent header correctly bumped to protobuf 6.33.2Version banner and
PROTOBUF_VERSION != 6033002guard are consistent with the core protobuf update; public message APIs remain unchanged.deps/protobuf/src/google/protobuf/empty.pb.h (1)
4-19:google.protobuf.Emptyheader version metadata correctly updatedThe version comment and
PROTOBUF_VERSIONguard now match 6.33.2; theEmptymessage API and wire format stay intact.
| declaration = { | ||
| number: 1100, | ||
| full_name: ".imp.impress_feature_set", | ||
| type: ".imp.ImpressFeatureSet" | ||
| }, |
There was a problem hiding this comment.
🧩 Analysis chain
🏁 Script executed:
rg -nP --type=proto -C5 'message\s+ImpressFeatureSet\s*\{'Repository: nodesource/nsolid
Length of output: 90
🏁 Script executed:
rg -nP -C5 'message\s+ImpressFeatureSet\s*\{' --glob='*.proto'Repository: nodesource/nsolid
Length of output: 43
🏁 Script executed:
rg -i 'impressfeatureset' --glob='*.proto'Repository: nodesource/nsolid
Length of output: 148
🏁 Script executed:
rg -n '\.imp\.' --glob='*.proto' descriptor.protoRepository: nodesource/nsolid
Length of output: 117
🏁 Script executed:
rg -n '\.imp' deps/protobuf/src/google/protobuf/descriptor.protoRepository: nodesource/nsolid
Length of output: 152
🏁 Script executed:
sed -n '1185,1200p' deps/protobuf/src/google/protobuf/descriptor.protoRepository: nodesource/nsolid
Length of output: 503
🏁 Script executed:
rg 'ImpressFeatureSet' --type-list | head -20 && rg 'ImpressFeatureSet'Repository: nodesource/nsolid
Length of output: 555
The ImpressFeatureSet message type is not defined in the codebase.
The extension declaration references type .imp.ImpressFeatureSet, but no corresponding message definition exists in the repository. The extension declaration itself is syntactically correct and the number 1100 is within the valid range, but the referenced message type must be defined before this extension can be used. Add the ImpressFeatureSet message definition to the proto file.
🤖 Prompt for AI Agents
In deps/protobuf/src/google/protobuf/descriptor.proto around lines 1191-1195,
the extension declaration references .imp.ImpressFeatureSet but no such message
is defined; add a protobuf message type named ImpressFeatureSet in the imp
package (or the same proto file) with the required fields (or at minimum an
empty placeholder message) so the fully-qualified type .imp.ImpressFeatureSet
exists, place this message definition before or in the same file as the
extension reference, and then regenerate any language-specific protobuf
artifacts to pick up the new type.
| // Generated by the protocol buffer compiler. DO NOT EDIT! | ||
| // NO CHECKED-IN PROTOBUF GENCODE | ||
| // source: google/protobuf/timestamp.proto | ||
| // Protobuf C++ Version: 6.33.0 | ||
| // Protobuf C++ Version: 6.33.2 |
There was a problem hiding this comment.
🧩 Analysis chain
🏁 Script executed:
#!/bin/bash
# Verify protobuf 6.33.2 release and check version consistency in generated files
# Check if protobuf 6.33.2 is a valid release
echo "=== Checking protobuf 6.33.2 release ==="
curl -s https://api.github.com/repos/protocolbuffers/protobuf/releases | jq '.[] | select(.tag_name == "v6.33.2") | {tag_name, published_at, prerelease}'
echo ""
echo "=== Checking version consistency in generated files ==="
# Find all .pb.cc and .pb.h files and extract version info
fd -e "\.pb\.(cc|h)" . --exec grep -H "Protobuf C++ Version:" {} \; | sort | uniq -c | sort -rnRepository: nodesource/nsolid
Length of output: 158
🏁 Script executed:
#!/bin/bash
# Check if the timestamp.pb.cc file exists and contains the version marker
echo "=== Checking for timestamp.pb.cc ==="
find . -name "timestamp.pb.cc" -type f 2>/dev/null
echo ""
echo "=== Listing all .pb.cc and .pb.h files in deps/protobuf ==="
find deps/protobuf -name "*.pb.cc" -o -name "*.pb.h" 2>/dev/null | head -20
echo ""
echo "=== Reading first 10 lines of timestamp.pb.cc if it exists ==="
if [ -f "deps/protobuf/src/google/protobuf/timestamp.pb.cc" ]; then
head -10 "deps/protobuf/src/google/protobuf/timestamp.pb.cc"
else
echo "File not found at expected path"
fi
echo ""
echo "=== Checking version markers in any .pb.cc files ==="
find deps/protobuf -name "*.pb.cc" -type f 2>/dev/null -exec grep -H "Protobuf C++ Version" {} \; | head -10Repository: nodesource/nsolid
Length of output: 2491
🌐 Web query:
protobuf 6.33.2 release official
💡 Result:
I can't find an official release named "protobuf 6.33.2." The latest visible releases around this line are:
- Protocol Buffers site showing the 6.x line (6.33 as the latest 6.x minor in their support chart). [1]
- GitHub Releases shows protoc/protobuf v33.2 published Dec 5, 2025 (protoc artifacts and source). [2]
Do you mean protoc/protobuf v33.2 (GitHub release) or a Protobuf package version "6.33.2"? If you want the official release page or downloads for v33.2, I can link them.
Sources: [1] protobuf.dev version/support, [2] protocolbuffers/protobuf GitHub releases.
🌐 Web query:
protobuf version 6.33.2 official release protocol buffers
💡 Result:
I couldn't find an official protobuf release named "6.33.2." The current official release is Protocol Buffers v33.2 (published Dec 5, 2025). See the GitHub release and the protobuf news/docs. [1][2]
Sources:
- Protocol Buffers releases (GitHub) — v33.2 release assets and notes. [1]
- Protocol Buffers news / documentation (v30+ announcements referencing versioning). [2]
🌐 Web query:
protobuf v33.2 release December 2025
💡 Result:
Protocol Buffers v33.2 was released Dec 5, 2025 (tag v33.2). Key items in the changelog include adding EDITION_UNSTABLE, fixes for custom features outside the pb package, and other compiler/C++ fixes. [1][2][3]
Sources:
- GitHub releases (v33.2 tag). [1]
- Git tag on googlesource showing tag date Dec 5, 2025. [2]
- Changelog / release notes summary. [3]
🏁 Script executed:
#!/bin/bash
# Check all .pb.h files to see if they have consistent version markers
echo "=== Checking all .pb.h files for version consistency ==="
find deps/protobuf -name "*.pb.h" -type f 2>/dev/null -exec grep -H "Protobuf C++ Version" {} \; | sort | uniq -c
echo ""
echo "=== Count of files with version 6.33.2 ==="
find deps/protobuf -name "*.pb.*" -type f 2>/dev/null -exec grep -l "6.33.2" {} \; | wc -l
echo ""
echo "=== Count of .pb.cc files total ==="
find deps/protobuf -name "*.pb.cc" -type f 2>/dev/null | wc -l
echo ""
echo "=== Count of .pb.h files total ==="
find deps/protobuf -name "*.pb.h" -type f 2>/dev/null | wc -lRepository: nodesource/nsolid
Length of output: 1497
Regenerate protobuf files with correct version marker — version "6.33.2" does not exist.
The generated files in deps/protobuf are marked with "Protobuf C++ Version: 6.33.2," but this is not an official protobuf release. The official release is v33.2 (published Dec 5, 2025). All 28 generated .pb.cc and .pb.h files consistently use the incorrect version marker and must be regenerated with the correct version number.
🤖 Prompt for AI Agents
In deps/protobuf/src/google/protobuf/timestamp.pb.cc around lines 1 to 4, the
generated file header incorrectly states "Protobuf C++ Version: 6.33.2";
regenerate all protobuf-generated files (all 28 .pb.cc/.pb.h in deps/protobuf)
using the correct protobuf compiler/version so the header shows the official
version (v33.2 or the exact version string your build uses), replace the
incorrect version markers in the regenerated outputs, and verify the generator
invocation and build tooling point to the correct protoc/plugin version before
committing.
PR-URL: #398 Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com>
santigimeno
force-pushed
the
santi/update_protobuf
branch
from
e0d64c7 to
248834e
Compare
PR-URL: #398 Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com>
|
Landed in 751b622 |
PR-URL: #398 Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com>
PR-URL: #398 Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com>
Summary by CodeRabbit
✏️ Tip: You can customize this high-level summary in your review settings.