src: set name to nsolid threads

[santigimeno]

Fixes: #197

Summary by CodeRabbit

• Improvements
  • Enhanced thread identification by assigning descriptive names to internal agent threads, improving visibility when using system monitoring tools and debuggers for performance analysis and troubleshooting.

_{✏️ Tip: You can customize this high-level summary in your review settings.}

[coderabbitai]

Walkthrough

Thread naming calls were added to five agent and NSolid thread routines using uv_thread_setname() with descriptive identifiers (NSolidGrpcAgent, NSolidOTLPAgent, NSolidStatsDAgent, NSolidZmqAgent, NSolidThread) to improve debugging visibility via system tools.

Changes

Cohort / File(s)	Summary
Agent thread naming agents/grpc/src/grpc_agent.cc, agents/otlp/src/otlp_agent.cc, agents/statsd/src/statsd_agent.cc, agents/zmq/src/zmq_agent.cc	Added uv_thread_setname() call in respective run_() methods to set OS-level thread names (NSolidGrpcAgent, NSolidOTLPAgent, NSolidStatsDAgent, NSolidZmqAgent)
Main NSolid thread naming src/nsolid/nsolid_api.cc	Added uv_thread_setname("NSolidThread") in EnvList::env_list_routine_() before starting the blocked loop timer

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~3 minutes

• Highly consistent, repetitive pattern applied uniformly across five files with minimal code additions
• Single-line functionality additions with no behavioral or control flow changes
• Changes are straightforward and low-risk platform-specific instrumentation

Poem

🐰 Thread names now shine so bright and clear,
No more mystery which agent's here—
Grpc, Otlp, Statsd too,
Zmq, NSolid, each one true!
Debuggers smile from far and near! ✨

Pre-merge checks and finishing touches

❌ Failed checks (1 warning)

Check name	Status	Explanation	Resolution
Docstring Coverage	⚠️ Warning	Docstring coverage is 33.33% which is insufficient. The required threshold is 80.00%.	You can run @coderabbitai generate docstrings to improve docstring coverage.

✅ Passed checks (4 passed)

Check name	Status	Explanation
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Title check	✅ Passed	The title 'src: set name to nsolid threads' clearly and concisely describes the main change: setting descriptive names for nsolid-related threads across multiple agent files.
Linked Issues check	✅ Passed	The PR implements thread naming for NSolid agent threads (GRPC, OTLP, StatsD, ZMQ) and the EnvList routine thread, directly addressing issue #197's objective to assign descriptive names to nsolid built-in threads for better debugging.
Out of Scope Changes check	✅ Passed	All changes are scoped to adding thread naming calls in NSolid-specific agent run methods and the EnvList routine, with no unrelated modifications.

✨ Finishing touches

• 📝 Generate docstrings

🧪 Generate unit tests (beta)

• Create PR with unit tests
• Post copyable unit tests in a comment
• Commit unit tests in branch santi/thread_names

---

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

[coderabbitai]

Actionable comments posted: 1

📜 Review details

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between fcab189 and 9611740.

📒 Files selected for processing (5)

• agents/grpc/src/grpc_agent.cc (1 hunks)
• agents/otlp/src/otlp_agent.cc (1 hunks)
• agents/statsd/src/statsd_agent.cc (1 hunks)
• agents/zmq/src/zmq_agent.cc (1 hunks)
• src/nsolid/nsolid_api.cc (1 hunks)

⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (8)

• GitHub Check: coverage-linux-without-intl
• GitHub Check: lint-js-and-md
• GitHub Check: build-tarball
• GitHub Check: test-linux (ubuntu-24.04-arm)
• GitHub Check: test-linux (ubuntu-24.04)
• GitHub Check: coverage-linux
• GitHub Check: coverage-windows
• GitHub Check: test-macOS

🔇 Additional comments (4)

agents/grpc/src/grpc_agent.cc (1)

707-707: LGTM! Thread naming improves debugging visibility.

The thread name "NSolidGrpcAgent" (15 characters) fits within the Linux 16-character limit and will make this thread easily identifiable in debuggers and system tools like htop.

agents/zmq/src/zmq_agent.cc (1)

812-812: LGTM! Consistent thread naming implementation.

The thread name "NSolidZmqAgent" (14 characters) is within the Linux 16-character limit and follows the same pattern as the other agent threads.

agents/otlp/src/otlp_agent.cc (1)

244-244: LGTM! Thread naming enhances observability.

The thread name "NSolidOTLPAgent" (15 characters) fits within the Linux 16-character limit and will help identify this agent thread in debuggers and system monitoring tools.

src/nsolid/nsolid_api.cc (1)

1646-1654: No action needed—libuv support is already confirmed and the implementation is consistent with existing patterns

The USE(uv_thread_setname("NSolidThread")); call at line 1648 is correct. Verification shows:

• uv_thread_setname is already declared in the bundled deps/uv/include/uv.h (line 1921) and widely used throughout the codebase (10+ call sites) with no version guards, confirming it is stable and available.
• The USE() wrapper is consistent with all four agent thread naming patterns (NSolidGrpcAgent, NSolidZmqAgent, NSolidStatsDAgent, NSolidOTLPAgent).
• The "NSolidThread" name follows the established "NSolid*" naming convention.

The optional suggestion to use a more specific name (e.g., "NSolidEnvList") for better debugger visibility is valid but not critical.

[santigimeno]

Landed in ba6c1d0