Skip to content

Conversation

@santigimeno
Copy link
Member

@santigimeno santigimeno commented Feb 3, 2026

A couple of changes:

  • Extend time between enabling/disabling cont profiles.
  • Fix last test to make sure it start with cont profile disabled.

Summary by CodeRabbit

  • Tests
    • Improved CPU profiling test timing and validation to enhance test stability
    • Enhanced test assertions to verify profile data integrity during continuous profiling operations

A couple of changes:
- Extend time between enabling/disabling cont profiles.
- Fix last test to make sure it start with cont profile disabled.
@santigimeno santigimeno requested a review from RafaelGSS February 3, 2026 16:24
@santigimeno santigimeno self-assigned this Feb 3, 2026
@coderabbitai
Copy link

coderabbitai bot commented Feb 3, 2026

Walkthrough

A test file for gRPC continuous profiling was updated with increased timing delays, added console logging for profile counts, duplicated environment variable cleanup, and enhanced return value destructuring with assertions to verify profile data and request IDs.

Changes

Cohort / File(s) Summary
Test Timing & Assertions
test/agents/test-grpc-continuous-profile.mjs
Increased several timing waits from 250ms to 500ms, added 500ms delays for asset toggle operations, added console.log statements to report profile counts, duplicated NSOLID_CONT_CPU_PROFILE deletion in env setup, enhanced grpcServer.cpuProfile return value destructuring to capture data and requestId with validation assertions.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

Poem

🐰 Whiskers twitched with timing delight,
500ms waits now burn so bright,
Data and requestId dance in place,
Assertions verify each trace,
Test stability wins the race!

🚥 Pre-merge checks | ✅ 3
✅ Passed checks (3 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title 'test: fix flaky test-grpc-continuous-profile' directly and clearly describes the main change: fixing flakiness in a specific test file.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing touches
  • 📝 Generate docstrings
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch santi/deflake_test_grpc_cont

Comment @coderabbitai help to get the list of available commands and usage tips.

santigimeno added a commit that referenced this pull request Feb 5, 2026
A couple of changes:
- Extend time between enabling/disabling cont profiles.
- Fix last test to make sure it start with cont profile disabled.

PR-URL: #418
Reviewed-By: Rafael Gonzaga <[email protected]>
@santigimeno
Copy link
Member Author

Landed in f4360e5

@santigimeno santigimeno closed this Feb 5, 2026
@santigimeno santigimeno deleted the santi/deflake_test_grpc_cont branch February 5, 2026 12:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants