Skip to content

fix: avoid try/except inside a loop #419

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
santigimeno wants to merge 1 commit into from
+7 −4
Closed

fix: avoid try/except inside a loop #419

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 7 additions & 4 deletions tools/install.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -165,14 +165,17 @@ def nsolid_cli_files(options, action):
def nsolid_strict_files(options, action):
target_path = 'lib/node_modules/ncm-ng/'

for dirname, subdirs, basenames in os.walk('deps/ncm-ng', topdown=True):
def safe_action(paths, destination):
try:
subdirs[:] = filter('test'.__ne__, subdirs) # skip test suites
paths = [os.path.join(dirname, basename) for basename in basenames]
action(options, paths, target_path + dirname[11:] + '/')
action(options, paths, destination)
except:
pass

for dirname, subdirs, basenames in os.walk('deps/ncm-ng', topdown=True):
subdirs[:] = filter('test'.__ne__, subdirs) # skip test suites
paths = [os.path.join(dirname, basename) for basename in basenames]
safe_action(paths, target_path + dirname[11:] + '/')

# create/remove symlink
link_path = abspath(options.install_path, 'bin/ncm-agent')
if action == uninstall:
Expand Down
Loading