-
Notifications
You must be signed in to change notification settings - Fork 0
feat!: rename FaceImage class to FaceImagePayload & remove ReadMemberLayoutAsync overload
#405
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR renames the FaceImage class to FaceImagePayload and removes a method overload for ReadMemberLayoutAsync to improve API clarity and naming consistency.
Key changes:
- Renamed
FaceImageentity class toFaceImagePayloadfor better semantic clarity - Removed the parameterless
ReadMemberLayoutAsync()overload in favor of a single method with default parameters - Updated all references, tests, and API documentation to reflect the new naming
Reviewed Changes
Copilot reviewed 9 out of 9 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| FaceImagePayload.cs | Renamed the record class from FaceImage to FaceImagePayload |
| KaonaviClient.Member.cs | Updated method signatures to use FaceImagePayload instead of FaceImage |
| KaonaviClient.Layout.cs | Removed overload method and added default parameter value |
| Context.cs | Updated JSON serialization context for the renamed class |
| PublicAPI files | Updated API surface documentation for breaking changes |
| Test files | Updated test class names and references to use new FaceImagePayload name |
| Program.cs | Updated sample code to use explicit parameter naming |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #405 +/- ##
==========================================
- Coverage 97.72% 97.72% -0.01%
==========================================
Files 41 41
Lines 616 615 -1
Branches 58 58
==========================================
- Hits 602 601 -1
Misses 5 5
Partials 9 9
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
d907e54 to
fb84f17
Compare
fb84f17 to
3ac9799
Compare
3ac9799 to
5c806a5
Compare
close #403