Skip to content

Conversation

@nogic1008
Copy link
Owner

@nogic1008 nogic1008 commented Sep 27, 2025

close #403

@nogic1008 nogic1008 added this to the vNextMajor milestone Sep 27, 2025
@nogic1008 nogic1008 self-assigned this Sep 27, 2025
@nogic1008 nogic1008 requested a review from Copilot September 27, 2025 09:26
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR renames the FaceImage class to FaceImagePayload and removes a method overload for ReadMemberLayoutAsync to improve API clarity and naming consistency.

Key changes:

  • Renamed FaceImage entity class to FaceImagePayload for better semantic clarity
  • Removed the parameterless ReadMemberLayoutAsync() overload in favor of a single method with default parameters
  • Updated all references, tests, and API documentation to reflect the new naming

Reviewed Changes

Copilot reviewed 9 out of 9 changed files in this pull request and generated no comments.

Show a summary per file
File Description
FaceImagePayload.cs Renamed the record class from FaceImage to FaceImagePayload
KaonaviClient.Member.cs Updated method signatures to use FaceImagePayload instead of FaceImage
KaonaviClient.Layout.cs Removed overload method and added default parameter value
Context.cs Updated JSON serialization context for the renamed class
PublicAPI files Updated API surface documentation for breaking changes
Test files Updated test class names and references to use new FaceImagePayload name
Program.cs Updated sample code to use explicit parameter naming

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

@codecov
Copy link

codecov bot commented Sep 27, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 97.72%. Comparing base (b70f63a) to head (5029e5b).

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #405      +/-   ##
==========================================
- Coverage   97.72%   97.72%   -0.01%     
==========================================
  Files          41       41              
  Lines         616      615       -1     
  Branches       58       58              
==========================================
- Hits          602      601       -1     
  Misses          5        5              
  Partials        9        9              
Flag Coverage Δ
ARM64 97.72% <100.00%> (-0.01%) ⬇️
Linux 97.72% <100.00%> (-0.01%) ⬇️
X64 97.72% <100.00%> (-0.01%) ⬇️
macOS 97.72% <100.00%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@nogic1008 nogic1008 marked this pull request as draft September 27, 2025 10:06
@nogic1008 nogic1008 force-pushed the feat/rename-class branch 2 times, most recently from d907e54 to fb84f17 Compare September 28, 2025 00:54
@nogic1008 nogic1008 marked this pull request as ready for review November 23, 2025 02:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

FaceImageエンティティをFaceImagePayloadにリネームする

2 participants