Resolve dotnet path from DOTNET_HOST_PATH in VSTestTask#5
Closed
Resolve dotnet path from DOTNET_HOST_PATH in VSTestTask#5
Conversation
VSTestTask (legacy) was hardcoding 'dotnet' as the process filename, assuming it would be found on PATH. This changes it to resolve the dotnet executable using the same strategy as VSTestTask2: 1. Check DOTNET_HOST_PATH environment variable 2. Check current directory 3. Search PATH 4. Fall back to bare 'dotnet' name Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
VSTestTask (legacy) was hardcoding
"dotnet"as the process filename, assuming it would be found on PATH. This changes it to resolve the dotnet executable using the same strategy asVSTestTask2.GenerateFullPathToTool():DOTNET_HOST_PATHenvironment variablePATHdotnetnameValidation
./build.cmd -packRunDotnetTestWithCsprojacceptance test - 2/2 passed