Build isolated test assets for single TFM instead of 7#6
Closed
Build isolated test assets for single TFM instead of 7#6
Conversation
* Update matrix * Remove runtimes * Update test/TestAssets/MSTestProject2/UnitTest1.cs Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> * Update test/TestAssets/MSTestProject1/UnitTest1.cs Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> * Update eng/Versions.props Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> * Split tests * Remove skip that is no longer needed * wip * move tests * categories * Update pipelines * Apply suggestions from code review Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> * Apply suggestion from @nohwnd * Apply suggestion from @nohwnd * remove extra file * Potential fix for pull request finding Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com> * don't 'silently' skip * speed up blame, and fix paralllization of tests that check process count * Fix the flag * fix typo in the parameter name * Revert not filtering on linux * missing runsettings * Allow changing test runner arguments in proj * Typo * pr fixes * Duplicated test * move changes, add some more speedups * fx * Fix procdump tests * Resolve test assets from global if needed * Increase timeout * Break infinite restore loop in VS * Go back to default timeout on wrapper, cannot repro locally * timeout? * Add more diags, and hopefully upload logs * where did I put the serialization? * print logs * fix errors for moved logs folder * Upload artifacts * thread safe list * Flakiness * Indicator test flakiness * revert diag log * Using --------- Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
* Fix ci build * filter
GetIsolatedTestAsset now takes a targetFramework parameter and rewrites the csproj to build only that TFM. Previously, test assets built for all 7 target frameworks (net462;net472;net48;net8.0;net9.0;net10.0;net11.0) even though the test assertions only need output from one. Results on affected tests: - MSBuildLoggerCanBeEnabledByBuildPropertyAndDoesNotEatSpecialChars: 76s -> 15s - RunDotnetTestWithCsprojPassInlineSettings: 62s -> 15s - MSBuildLoggerCanBeDisabledByEnvironmentVariableProperty: 83s -> 66s - MSBuildLoggerCanBeDisabledByBuildProperty: 50s -> ~15s (estimated) - RunDotnetTestWithCsproj: 45s -> ~15s (estimated) - RunSettingsAreLoadedFromProject: 31s -> ~15s (estimated) Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
\GetIsolatedTestAsset\ now takes a \ argetFramework\ parameter and rewrites the csproj to build only that TFM. Previously, test assets built for all 7 target frameworks (
et462;net472;net48;net8.0;net9.0;net10.0;net11.0) even though the test assertions only need output from one.
Before/After (measured)
Changes
unnerInfo.TargetFramework\