Conversation
clezag
requested changes
Aug 12, 2025
Member
clezag
left a comment
clezag
left a comment
There was a problem hiding this comment.
IIRC, Kubernetes/helm has problems with .yaml files that have comment headers.
Please use the REUSE.toml file to set the license of .yaml/.yml files and remove the header. Not sure about the .tpl files, but better to do the same for them as well.
docker-compose.yml files are fine with the header
.github/workflows/reuse-lint.yml
Outdated
Member
There was a problem hiding this comment.
Please use the existing reuse-action supplied by the REUSE upstream, e.g. https://github.com/noi-techpark/opendatahub-timeseries-api/blob/main/.github/workflows/reuse.yml
Member
There was a problem hiding this comment.
This does not look right. Json file don't support comments, you have to use a .license file or the REUSE.toml
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Ensure full compliance with REUSE specification.