Skip to content

Conversation

@Snezhkko
Copy link

@Snezhkko Snezhkko commented Dec 8, 2025

The ACIR text lexer stored a done flag that was only written at EOF and never read, unlike the frontend lexer where this flag drives the Iterator implementation. The ACIR parser relies solely on the Eof token to detect end of input, so keeping the flag adds unnecessary state and can confuse future maintainers. This change removes the dead done field, its initialization, and the EOF assignment without altering lexer or parser behavior.

@github-actions
Copy link
Contributor

github-actions bot commented Dec 8, 2025

Thank you for your contribution to the Noir language.

Please do not force push to this branch after the Noir team have started review of this PR. Doing so will only delay us merging your PR as we will need to start the review process from scratch.

Thanks for your understanding.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant