chore: remove decompose function #92
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jialinli98
force-pushed
the
jl/remove_decompose
branch
from
ac3fa01 to
1cc89f6
Compare
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
There was a problem hiding this comment.
⚠️ Performance Alert ⚠️
Possible performance regression was detected for benchmark 'ACIR Opcodes'.
Benchmark result of this commit is worse than the previous benchmark result exceeding threshold 1.01.
| Benchmark suite | Current: b79ff1d | Previous: 15df67c | Ratio |
|---|---|---|---|
get_string_JSON16kb_Bench.json/main |
43258 acir_opcodes |
42695 acir_opcodes |
1.01 |
get_string_JSON512b_Bench.json/main |
27386 acir_opcodes |
26823 acir_opcodes |
1.02 |
get_value_JSON16kb_Bench.json/main |
20747 acir_opcodes |
20188 acir_opcodes |
1.03 |
get_value_JSON512b_Bench.json/main |
4875 acir_opcodes |
4316 acir_opcodes |
1.13 |
This comment was automatically generated by workflow using github-action-benchmark.
There was a problem hiding this comment.
⚠️ Performance Alert ⚠️
Possible performance regression was detected for benchmark 'Circuit Size'.
Benchmark result of this commit is worse than the previous benchmark result exceeding threshold 1.01.
| Benchmark suite | Current: b79ff1d | Previous: 15df67c | Ratio |
|---|---|---|---|
get_value_JSON16kb_Bench.json/main |
36167 circuit_size |
35344 circuit_size |
1.02 |
get_value_JSON512b_Bench.json/main |
10373 circuit_size |
9550 circuit_size |
1.09 |
This comment was automatically generated by workflow using github-action-benchmark.
jialinli98
force-pushed
the
jl/remove_decompose
branch
3 times, most recently
from
a9f97fb to
e94e705
Compare
jialinli98
force-pushed
the
jl/remove_decompose
branch
from
d1a3c32 to
deab3c5
Compare
TomAFrench
approved these changes
Aug 26, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Problem*
same as #79 except this kept the arithmetic operations. If we replace them with if statements, benchmark checks will fail.
Summary*
Additional Context
PR Checklist*
cargo fmton default settings.