ai perf: low risk

Author: fchn289

src/domino/Domino.cpp

@@ -52,7 +52,7 @@ bool Domino::deduceStateSelf_(const Event& aValidEv, bool aPrevType) const noexc
 void Domino::effect_() noexcept
 {
     for (auto&& ev : effectEVs_)
-        if (state(ev) == true)  // avoid multi-change
+        if (states_[ev] == true)  // avoid multi-change; skip bounds check since effectEVs_ are validated
             effect_(ev);
     effectEVs_.clear();
 }

src/domino/WbasicDatDom.hpp

@@ -115,7 +115,7 @@ bool WbasicDatDom<aDominoType>::wbasic_replaceDataOK(const Domino::EvName& aEvNa
 template<typename aDominoType>
 bool WbasicDatDom<aDominoType>::wrCtrlOk(const Domino::EvName& aEvName, const bool aNewState) noexcept
 {
-    if (aDominoType::getData(aEvName).get() != nullptr)
+    if (aDominoType::getData(aEvName))
     {
         WRN("(WbasicDatDom) !!! Failed to change wrCtrl when aleady own data(out-of-ctrl), EvName=" << aEvName);
         return false;

src/log/UniBaseLog.hpp

@@ -64,27 +64,30 @@ inline const char* mt_timestamp() noexcept
 const char ULN_DEFAULT[] = "DEFAULT";
 
 // ***********************************************************************************************
-// - MT safe : yes (aStr is copied)
+// - MT safe : yes (aStr is const ref)
 // - mem safe: yes
-inline void cout_ascii(std::string aStr) noexcept
+inline void cout_ascii(const std::string& aStr) noexcept
 {
     try {  // cout may except(eg ios_base::failure) though rare; try-catch is safest as a log
-        std::cout << std::hex;
+        std::string buf;
+        buf.reserve(aStr.size() * 2);
         unsigned char preC = 0;
         for (unsigned char c : aStr)
         {
             if (std::isprint(c))
             {
                 if (preC == 0xd || preC == 0xa)
                 {
-                    std::cout << std::endl;
+                    buf += '\n';
                     preC = 0;
                 }
-                std::cout << c;
+                buf += static_cast<char>(c);
             }
             else
             {
-                std::cout << "[`" << static_cast<size_t>(c) << "'}";  // [`'} is rare
+                char hex[16];
+                snprintf(hex, sizeof(hex), "[`%zx'}", static_cast<size_t>(c));
+                buf += hex;
                 preC = c;
             }
         }

src/thread/MtInQueue.hpp

@@ -88,7 +88,7 @@ template<class aEleType>
 bool MtInQueue::mt_pushOK(S_PTR<aEleType>&& aEle) noexcept
 {
     // validate aEle
-    if (aEle.get() == nullptr)
+    if (!aEle)
     {
         HID("!!! can't push nullptr since pop empty will ret nullptr");
         return false;

src/thread/ThPoolBack.cpp

@@ -50,8 +50,8 @@ ThPoolBack::ThPoolBack(size_t aMaxThread)
                     task();  // packaged_task saves exception in its future
 
                     // no lock so can only use MT_safe part in "this"
-                    this->mt_nDoneFut_.fetch_add(1, std::memory_order_relaxed);  // fastest +1
-                    mt_pingMainTH();  // notify mainTH 1 task done
+                    if (this->mt_nDoneFut_.fetch_add(1, std::memory_order_release) == 0)  // +1 & ping only if first done
+                        mt_pingMainTH();
                 }
             });  // thread main()
         }  // for-loop to create threads

src/thread/ThreadBack.cpp

@@ -14,6 +14,7 @@ size_t ThreadBack::hdlDoneFut(UniLog& oneLog) noexcept
 {
     size_t nHandledFut = 0;
     const auto nDoneFut = mt_nDoneFut_.load(memory_order_relaxed);  // since mt_nDoneFut_+1 may before future::ready
+    if (nDoneFut == 0) return 0;
     // HID("(ThreadBack) nHandled=" << nHandledFut << '/' << nDoneFut << '|' << nFut());
 
     // bugFix: may mt_nDoneFut_+1 before future::ready, so must check "fut_backFN != fut_backFN_S_.end()"