Skip to content

Conversation

@he0119
Copy link
Member

@he0119 he0119 commented Nov 20, 2024

创建环境失败的时候没法获取到测试的插件版本号。

@github-actions github-actions bot added the bug Something isn't working label Nov 20, 2024
@codecov
Copy link

codecov bot commented Nov 20, 2024

Codecov Report

Attention: Patch coverage is 83.33333% with 1 line in your changes missing coverage. Please review.

Project coverage is 87.50%. Comparing base (88b919a) to head (99088ab).

✅ All tests successful. No failed tests found.

Files with missing lines Patch % Lines
src/providers/docker_test/plugin_test.py 75.00% 1 Missing ⚠️

❗ There is a different number of reports uploaded between BASE (88b919a) and HEAD (99088ab). Click for more details.

HEAD has 1 upload less than BASE
Flag BASE (88b919a) HEAD (99088ab)
2 1
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #279      +/-   ##
==========================================
- Coverage   92.68%   87.50%   -5.19%     
==========================================
  Files          36       37       +1     
  Lines        1831     1992     +161     
==========================================
+ Hits         1697     1743      +46     
- Misses        134      249     +115     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@he0119 he0119 requested a review from BigOrangeQWQ November 20, 2024 04:10
Copy link
Member

@BigOrangeQWQ BigOrangeQWQ left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

不使用pypi请求作为版本号的备选项了吗

@he0119
Copy link
Member Author

he0119 commented Nov 20, 2024

不使用pypi请求作为版本号的备选项了吗

对,如果都能从插件测试中获取的话,应该就没必要了吧。这样也能确保测试的版本号正确,因为 pypi 有可能会因为缓存问题导致测试版本号和 pypi 版本号不一致。

@he0119 he0119 merged commit 5de390a into main Nov 20, 2024
3 of 5 checks passed
@he0119 he0119 deleted the fix/extract_version branch November 20, 2024 05:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants