This repository was archived by the owner on Oct 20, 2022. It is now read-only.
Feature/jss 8 migration #250
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
Author
bstream
suggested changes
Jul 20, 2017
Contributor
bstream
left a comment
bstream
left a comment
There was a problem hiding this comment.
Remove sinopia references from yarn.lock 😎
Member
Author
|
i guess we need .npmrc file in here |
Member
Author
|
@bstream but apart from lock file issues, what do you think of this? |
iamstarkov
force-pushed
the
feature/jss-8-migration
branch
from
00639e3 to
75c2305
Compare
Member
Author
|
@bstream fixed registry issue |
Contributor
|
Hot stuff |
Member
Author
|
Published as |
Member
Author
|
I also added some compatibility notes in the readme |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
we need to utilise jss@8, to migrate to react-jss iteratively.
but jss-theme-reactor is abandoned, so me and @RikardGehlin rewrote it nathanmarks/jss-theme-reactor#46 and republished it https://www.npmjs.com/package/@iamstarkov/jss-theme-reactor
in the app we would need to use webpack's
resolve.aliases while all modules are being rewritten to react-jss