Use --reporter github-actions-logging option#31
Open
liamnichols wants to merge 1 commit intonorio-nomura:masterfrom
Open
Use --reporter github-actions-logging option#31liamnichols wants to merge 1 commit intonorio-nomura:masterfrom
liamnichols wants to merge 1 commit intonorio-nomura:masterfrom
Conversation
Author
|
Ah, the tests seem to fail because the output is ordered in a different way... I'm not completely sure why though since I see something about Any suggestions would be helpful 🙏 |
|
In case you don't already know, I had issues with this https://github.com/norio-nomura/action-swiftlint. @sinoru's version https://github.com/sinoru/actions-swiftlint solved most of them, and the code is clearly maintained. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
👋 Nice Action!
I wasn't aware of it until after I was digging into the SwiftLint source code, but there is actually a reporter that formats for the GitHub Action so we can avoid having to
sedstdout from now on 🚀(The reporter wasn't documented in SwiftLint's Readme but I've added it here: realm/SwiftLint/pull/3223)
I ran this on my test project and it seems to work, but please feel free to give it a try yourself first 🙏