Skip to content

Update docs deps#886

Merged
mlw merged 1 commit intomainfrom
mlw/update-docs-deps-2
Mar 31, 2026
Merged

Update docs deps#886
mlw merged 1 commit intomainfrom
mlw/update-docs-deps-2

Conversation

@mlw
Copy link
Copy Markdown
Contributor

@mlw mlw commented Mar 31, 2026

Bump versions

@mlw mlw requested a review from a team as a code owner March 31, 2026 10:51
@github-actions github-actions bot added docs Improvements or additions to documentation size/xl Size: extra large labels Mar 31, 2026
@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai bot commented Mar 31, 2026

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: 0a052559-83ae-4adf-a953-7e630109aafd

📥 Commits

Reviewing files that changed from the base of the PR and between d71cfd2 and dec4d2f.

⛔ Files ignored due to path filters (1)
  • docs/pnpm-lock.yaml is excluded by !**/pnpm-lock.yaml
📒 Files selected for processing (1)
  • docs/package.json
🚧 Files skipped from review as they are similar to previous changes (1)
  • docs/package.json

📝 Walkthrough

Walkthrough

The PR updates docs/package.json to bump the serialize-javascript override from version 7.0.3 to 7.0.5 and adds a new override for path-to-regexp to enforce version 0.1.13.

Changes

Cohort / File(s) Summary
Dependency Overrides
docs/package.json
Updated serialize-javascript override to 7.0.5 and added new path-to-regexp@<0.1.13 override to 0.1.13.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~2 minutes

Possibly related PRs

🚥 Pre-merge checks | ✅ 2
✅ Passed checks (2 passed)
Check name Status Explanation
Title check ✅ Passed The title 'Update docs deps' accurately describes the main change: updating dependency overrides in docs/package.json for serialize-javascript and path-to-regexp.
Description check ✅ Passed The description 'Bump versions' is related to the changeset, which updates dependency versions in package.json, though it is quite terse.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch mlw/update-docs-deps-2

Comment @coderabbitai help to get the list of available commands and usage tips.

Copy link
Copy Markdown
Contributor

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 3

🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.

Inline comments:
In `@docs/superpowers/plans/2026-03-28-dynamic-nats-push-client.md`:
- Around line 459-499: The plan step refers to non-existent symbols in
SNTSyncService.mm (the kvoWatchers property, SNTKVOManager import, and the KVO
watcher block) so update the plan: remove Task 7 or replace it with a concrete
change targeting actual existing symbols in SNTSyncService.mm; specifically
remove any references to kvoWatchers, SNTKVOManager, and the described watcher
in the plan text and ensure the plan instead points to the real lifecycle
trigger code currently present in SNTSyncService (search for methods like
spindown, enablePushNotifications, or the `@interface` SNTSyncService extension)
so the task matches the current file state.

In `@docs/superpowers/plans/2026-03-30-persisted-sync-intervals.md`:
- Around line 337-363: The test
testPreflightUsesPersistedIntervalWhenServerOmitsIt should assert that the
manager actually schedules using the persisted interval: after setting
SNTSyncManager.persistedFullSyncInterval = 3600 and calling [sm
preflightWithSyncState:ss], verify that rescheduleTimerQueue:secondsFromNow: was
invoked with the persisted value (3600) rather than kDefaultFullSyncInterval;
locate calls around preflightWithSyncState: and add a mock/spied expectation on
SNTSyncManager's rescheduleTimerQueue:secondsFromNow: to confirm the
persistedFullSyncInterval is passed through unchanged.
- Around line 124-141: The code reads persisted sync intervals using an
asynchronous proxy (id rop = [_daemonConn remoteObjectProxy]) so the reply
blocks passed to fullSyncInterval: and pushNotificationsFullSyncInterval: may
not run before you set _persistedFullSyncInterval and
_persistedPushNotificationsFullSyncInterval; change the proxy acquisition to use
synchronousRemoteObjectProxy (i.e., id rop = [_daemonConn
synchronousRemoteObjectProxy]) so the reply blocks execute before the subsequent
assignments, keeping the same call sites fullSyncInterval: and
pushNotificationsFullSyncInterval: and preserving the LOGD that prints
_persistedFullSyncInterval and _persistedPushNotificationsFullSyncInterval.
🪄 Autofix (Beta)

Fix all unresolved CodeRabbit comments on this PR:

  • Push a commit to this branch (recommended)
  • Create a new PR with the fixes

ℹ️ Review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: 01d7d113-6a19-4191-b756-434a22fef681

📥 Commits

Reviewing files that changed from the base of the PR and between 8be9e16 and d71cfd2.

⛔ Files ignored due to path filters (1)
  • docs/pnpm-lock.yaml is excluded by !**/pnpm-lock.yaml
📒 Files selected for processing (3)
  • docs/package.json
  • docs/superpowers/plans/2026-03-28-dynamic-nats-push-client.md
  • docs/superpowers/plans/2026-03-30-persisted-sync-intervals.md

Copy link
Copy Markdown
Member

@pmarkowsky pmarkowsky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good aside from the plans.

@mlw mlw force-pushed the mlw/update-docs-deps-2 branch from d71cfd2 to dec4d2f Compare March 31, 2026 12:23
@github-actions github-actions bot added the size/s Size: small label Mar 31, 2026
Copy link
Copy Markdown
Member

@pmarkowsky pmarkowsky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@mlw mlw merged commit 6becb3e into main Mar 31, 2026
3 checks passed
@mlw mlw deleted the mlw/update-docs-deps-2 branch March 31, 2026 12:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

docs Improvements or additions to documentation size/s Size: small size/xl Size: extra large

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants