This repository was archived by the owner on Jun 21, 2025. It is now read-only.
Plugin assembly loading fix #222
Open
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Cross-plugin dependency fix
This PR fixes an issue where plugins would not load if they referenced another plugin that was not yet loaded.
The problem:
Assume the following scenario:
The following plugins are to be loaded:
Both
PluginAandPluginCdepend onPluginB.PluginBhas no dependencies.PluginA's assembly is loaded.PluginA, but fails because the dependencyPluginBis not yet found.PluginB's assembly is loaded and initialized.PluginCis loaded and starts without any issues.Changes:
PluginAPI.Loader.PluginAssemblyInformationstructInitializing (count) plugins...This way, a plugin can reference another that comes after it alphabetically and will still be initialized correctly.