Open
Conversation
- Update @cashu/cashu-ts from ^2.1 to ^3.1 - Rename CashuWallet → Wallet, CashuMint → Mint - Rename methods: createMintQuote → createMintQuoteBolt11, createMeltQuote → createMeltQuoteBolt11, meltProofs → meltProofsBolt11 - Fix static method: CashuMint.getInfo() → new Mint().getInfo() - Fix keyset access: wallet.keys → wallet.keyChain.getCache() - Move P2PK handling from SendConfig to OutputConfig parameter - Move custom denominations to OutputConfig
pablof7z
commented
Feb 24, 2026
Collaborator
Author
pablof7z
left a comment
pablof7z
left a comment
There was a problem hiding this comment.
Code Review: cashu-ts v3 upgrade
The migration looks correct — class renames (CashuWallet→Wallet, CashuMint→Mint), method name updates, P2PK handling moved to OutputConfig, keyset access via wallet.keyChain.getCache().
However, this PR currently has merge conflicts with master (likely from version bumps and bun.lock changes since December). Given this is a 43-file change touching all package.json versions plus wallet internals, it will need a careful rebase.
@pablof7z This needs a rebase on current master to resolve the version/lockfile conflicts. The wallet code changes themselves look good.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
@cashu/cashu-tsfrom v2.1 to v3.1CashuWallet→Wallet,CashuMint→MintcreateMintQuoteBolt11,createMeltQuoteBolt11,meltProofsBolt11SendConfigtoOutputConfigparameterwallet.keyChain.getCache()Test plan