Open
Conversation
161164d to
a7c5d7f
Compare
a7c5d7f to
60830fc
Compare
|
Are there any issues blocking this PR? (I'd be happy to fix them) I've come across the exact same situation: (It could be implementable by the user, I think, but the |
Owner
|
@amatgil could you please rebase it? I'll merge it right away |
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Expands on top of #883, that should be merged first. This PR only adds the latest commit so review should focus on that.
This change adds a new function,
measure_multiline_textand updatesdraw_multiline_textto return the dimensions. I expanded thetext_wrapexample to show its results.Should solve #870.