add Image::as_app_icon to allow ergonomically setting the window icon#928
Open
cyrgani wants to merge 2 commits intonot-fl3:masterfrom
Open
add Image::as_app_icon to allow ergonomically setting the window icon#928cyrgani wants to merge 2 commits intonot-fl3:masterfrom
Image::as_app_icon to allow ergonomically setting the window icon#928cyrgani wants to merge 2 commits intonot-fl3:masterfrom
Conversation
cyrgani
changed the title
Image::as_app_icon to allow ergnomically setting the window iconImage::as_app_icon to allow ergonomically setting the window icon
Contributor
Author
|
An alternative would be to merge not-fl3/miniquad#540 first and then either close this PR or make |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds the function
Image::as_app_icon, which can be used to construct aminiquad::conf::Iconfor use in aConf. Previously, there was no practical way to do this, except to manually useinclude_bytes!and have three differently scaled versions. (best example of this: https://github.com/not-fl3/miniquad/blob/master/src/default_icon.rs)The PR also includes a small example that shows it is working as intended.
Note that this is built on top of #927.